Make a new abstract class for transformers.

This commit is contained in:
James Cole
2018-12-15 22:03:42 +01:00
parent 8ce43a3fe1
commit 747602a9cb
13 changed files with 30 additions and 121 deletions

View File

@@ -37,21 +37,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class CategoryTransformer
*/
class CategoryTransformer extends TransformerAbstract
class CategoryTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* CategoryTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -32,21 +32,16 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class CurrencyExchangeRateTransformer
*/
class CurrencyExchangeRateTransformer extends TransformerAbstract
class CurrencyExchangeRateTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* PiggyBankEventTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -31,21 +31,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class CurrencyTransformer
*/
class CurrencyTransformer extends TransformerAbstract
class CurrencyTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* CurrencyTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -32,21 +32,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class ImportJobTransformer
*/
class ImportJobTransformer extends TransformerAbstract
class ImportJobTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* PiggyBankTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -33,35 +33,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
*
* Class LinkTypeTransformer
*/
class LinkTypeTransformer extends TransformerAbstract
class LinkTypeTransformer extends AbstractTransformer
{
/**
* List of resources possible to include
*
* @var array
*/
protected $availableIncludes = [];
/**
* List of resources to automatically include
*
* @var array
*/
protected $defaultIncludes = [];
/** @var ParameterBag */
protected $parameters;
/**
* CurrencyTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -34,21 +34,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class PiggyBankEventTransformer
*/
class PiggyBankEventTransformer extends TransformerAbstract
class PiggyBankEventTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* PiggyBankEventTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -32,19 +32,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class PreferenceTransformer
*/
class PreferenceTransformer extends TransformerAbstract
class PreferenceTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* PreferenceTransformer constructor.
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -44,23 +44,17 @@ use Symfony\Component\HttpFoundation\ParameterBag;
*
* Class RecurringTransactionTransformer
*/
class RecurrenceTransformer extends TransformerAbstract
class RecurrenceTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/** @var RecurringRepositoryInterface */
protected $repository;
/**
* RecurrenceTransformer constructor.
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->repository = app(RecurringRepositoryInterface::class);
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -31,21 +31,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class RuleGroupTransformer
*/
class RuleGroupTransformer extends TransformerAbstract
class RuleGroupTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* CurrencyTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -34,21 +34,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class RuleTransformer
*/
class RuleTransformer extends TransformerAbstract
class RuleTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* CurrencyTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -35,22 +35,15 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class TagTransformer
*/
class TagTransformer extends TransformerAbstract
class TagTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* TagTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -1,6 +1,6 @@
<?php
/**
* JournalLinkTransformer.php
* TransactionLinkTransformer.php
* Copyright (c) 2018 thegrumpydictator@gmail.com
*
* This file is part of Firefly III.
@@ -32,23 +32,18 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
*
* Class JournalLinkTransformer
* Class TransactionLinkTransformer
*/
class JournalLinkTransformer extends TransformerAbstract
class TransactionLinkTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* CurrencyTransformer constructor.
* Constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}

View File

@@ -26,33 +26,25 @@ namespace FireflyIII\Transformers;
use FireflyIII\Models\Role;
use FireflyIII\User;
use League\Fractal\Resource\Collection as FractalCollection;
use League\Fractal\TransformerAbstract;
use Log;
use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class UserTransformer
*/
class UserTransformer extends TransformerAbstract
class UserTransformer extends AbstractTransformer
{
/** @var ParameterBag */
protected $parameters;
/**
* UserTransformer constructor.
*
* @codeCoverageIgnore
*
* @param ParameterBag $parameters
*/
public function __construct(ParameterBag $parameters)
public function __construct()
{
$this->parameters = $parameters;
if ('testing' === config('app.env')) {
Log::warning(sprintf('%s should not be instantiated in the TEST environment!', \get_class($this)));
}
}
/**
* Transform user.
*