Improve test coverage.

This commit is contained in:
James Cole
2018-03-03 17:16:47 +01:00
parent 9dc4c50527
commit 7542175258
28 changed files with 414 additions and 98 deletions

View File

@@ -26,27 +26,29 @@ namespace Tests\Unit\Middleware;
use Route;
use Symfony\Component\HttpFoundation\Response;
use Tests\TestCase;
use Log;
/**
* Class AuthenticateTest
*/
class AuthenticateTest extends TestCase
{
/**
* @covers \FireflyIII\Http\Middleware\Authenticate::handle
* @covers \FireflyIII\Http\Middleware\Authenticate
*/
public function testMiddleware()
{
Log::debug('Now at testMiddleware');
$response = $this->get('/_test/authenticate');
$this->assertEquals(Response::HTTP_FOUND, $response->getStatusCode());
$response->assertRedirect(route('login'));
}
/**
* @covers \FireflyIII\Http\Middleware\Authenticate::handle
* @covers \FireflyIII\Http\Middleware\Authenticate
*/
public function testMiddlewareAjax()
{
Log::debug('Now at testMiddlewareAjax');
//$this->withoutExceptionHandling();
$server = ['HTTP_X-Requested-With' => 'XMLHttpRequest'];
$response = $this->get('/_test/authenticate', $server);
@@ -54,20 +56,22 @@ class AuthenticateTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Middleware\Authenticate::handle
* @covers \FireflyIII\Http\Middleware\Authenticate
*/
public function testMiddlewareAuth()
{
Log::debug('Now at testMiddlewareAuth');
$this->be($this->user());
$response = $this->get('/_test/authenticate');
$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
}
/**
* @covers \FireflyIII\Http\Middleware\Authenticate::handle
* @covers \FireflyIII\Http\Middleware\Authenticate
*/
public function testMiddlewareBlockedUser()
{
Log::debug('Now at testMiddlewareBlockedUser');
$user = $this->user();
$user->blocked = 1;
@@ -80,10 +84,11 @@ class AuthenticateTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Middleware\Authenticate::handle
* @covers \FireflyIII\Http\Middleware\Authenticate
*/
public function testMiddlewareEmail()
{
Log::debug('Now at testMiddlewareEmail');
//$this->withoutExceptionHandling();
$user = $this->user();
$user->blocked = 1;

View File

@@ -35,7 +35,7 @@ use Tests\TestCase;
class IsDemoUserTest extends TestCase
{
/**
* @covers \FireflyIII\Http\Middleware\IsDemoUser::handle
* @covers \FireflyIII\Http\Middleware\IsDemoUser
*/
public function testMiddlewareAuthenticated()
{
@@ -45,9 +45,8 @@ class IsDemoUserTest extends TestCase
$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
}
/**
* @covers \FireflyIII\Http\Middleware\IsDemoUser::handle
* @covers \FireflyIII\Http\Middleware\IsDemoUser
*/
public function testMiddlewareNotAuthenticated()
{
@@ -56,6 +55,17 @@ class IsDemoUserTest extends TestCase
$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
}
/**
* @covers \FireflyIII\Http\Middleware\IsDemoUser
*/
public function testMiddlewareIsDemoUser()
{
$this->be($this->demoUser());
$response = $this->get('/_test/is-demo');
$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
$response->assertSessionHas('info');
}
/**
* Set up test
*/

View File

@@ -24,6 +24,8 @@ declare(strict_types=1);
namespace Tests\Unit\Middleware;
use FireflyIII\Http\Middleware\Range;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use Route;
use Symfony\Component\HttpFoundation\Response;
use Tests\TestCase;
@@ -34,14 +36,12 @@ use Tests\TestCase;
class RangeTest extends TestCase
{
/**
* @covers \FireflyIII\Http\Middleware\Range::handle
* @covers \FireflyIII\Http\Middleware\Range::__construct
* @covers \FireflyIII\Http\Middleware\Range::configureList
* @covers \FireflyIII\Http\Middleware\Range::configureView
* @covers \FireflyIII\Http\Middleware\Range::setRange
* @covers \FireflyIII\Http\Middleware\Range
*/
public function testMiddlewareAuthenticated()
{
$repository = $this->mock(JournalRepositoryInterface::class);
$repository->shouldReceive('first')->andReturn(TransactionJournal::first());
$this->withoutExceptionHandling();
$this->be($this->user());
$response = $this->get('/_test/range');
@@ -54,8 +54,7 @@ class RangeTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Middleware\Range::handle
* @covers \FireflyIII\Http\Middleware\Range::__construct
* @covers \FireflyIII\Http\Middleware\Range
*/
public function testMiddlewareNotAuthenticated()
{