kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-08-03 10:50:43 +02:00
parent b8b59b13a7
commit 75c2529d3e
23 changed files with 367 additions and 539 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@@ -431,31 +431,6 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
return $savePerMonth;
}
/**
* @param PiggyBankEvent $event
*
* @return int|null
*/
public function getTransactionWithEvent(PiggyBankEvent $event): ?int
{
$journal = $event->transactionJournal;
if (null === $journal) {
return null;
}
if ((float)$event->amount < 0) {
$transaction = $journal->transactions()->where('amount', '<', 0)->first();
return $transaction->id ?? null;
}
if ((float)$event->amount > 0) {
$transaction = $journal->transactions()->where('amount', '>', 0)->first();
return $transaction->id ?? null;
}
return null;
}
/**
* Get for piggy account what is left to put in piggies.
*

7
app/Repositories/PiggyBank/PiggyBankRepositoryInterface.php
View File

@@ -199,13 +199,6 @@ interface PiggyBankRepositoryInterface
*/
public function getSuggestedMonthlyAmount(PiggyBank $piggyBank): string;
/**
* @param PiggyBankEvent $event
*
* @return int|null
*/
public function getTransactionWithEvent(PiggyBankEvent $event): ?int;
/**
* Get for piggy account what is left to put in piggies.
*