kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-08-03 10:50:43 +02:00
parent b8b59b13a7
commit 75c2529d3e
23 changed files with 367 additions and 539 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Transformers/TransactionGroupTransformer.php
View File

@@ -101,7 +101,6 @@ class TransactionGroupTransformer extends AbstractTransformer
*/
public function transformObject(TransactionGroup $group): array
{
//$first = $group->transactionJournals->first();
$result = [
'id' => (int)$group->id,
'created_at' => $group->created_at->toAtomString(),
@@ -174,11 +173,13 @@ class TransactionGroupTransformer extends AbstractTransformer
// get foreign amount:
$foreignAmount = null;
// @codeCoverageIgnoreStart
if (null !== $source->foreign_amount) {
$foreignAmount = TransactionType::WITHDRAWAL !== $type
? app('steam')->negative($source->foreign_amount)
: app('steam')->positive($source->foreign_amount);
}
// @codeCoverageIgnoreEnd
$metaFieldData = $this->groupRepos->getMetaFields($journal->id, $this->metaFields);
$metaDateData = $this->groupRepos->getMetaDateFields($journal->id, $this->metaDateFields);
@@ -280,7 +281,7 @@ class TransactionGroupTransformer extends AbstractTransformer
}
$foreignAmount = null;
if (null !== $row['foreign_amount']) {
$foreignAmount = TransactionType::WITHDRAWAL !== $type ? bcmul($row['foreign_amount'], '-1') : $row['foreign_amount'];
$foreignAmount = TransactionType::WITHDRAWAL !== $type ? bcmul($row['foreign_amount'], '-1') : $row['foreign_amount']; // @codeCoverageIgnore
}
$metaFieldData = $this->groupRepos->getMetaFields((int)$row['transaction_journal_id'], $this->metaFields);