From 784494871dc120da47b982a3a448a908e7ca45d4 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 1 Jul 2025 19:33:43 +0200 Subject: [PATCH] Fix #10530 --- app/TransactionRules/Actions/SetDescription.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/TransactionRules/Actions/SetDescription.php b/app/TransactionRules/Actions/SetDescription.php index cec857fc5a..1a0ac77257 100644 --- a/app/TransactionRules/Actions/SetDescription.php +++ b/app/TransactionRules/Actions/SetDescription.php @@ -28,6 +28,7 @@ use FireflyIII\Models\RuleAction; use FireflyIII\Models\TransactionJournal; use FireflyIII\TransactionRules\Traits\RefreshNotesTrait; use Illuminate\Support\Facades\DB; +use Illuminate\Support\Facades\Log; /** * Class SetDescription. @@ -51,7 +52,12 @@ class SetDescription implements ActionInterface $after = $this->action->getValue($journal); // replace newlines. - $after = str_replace(["\r", "\n", "\t", "\036", "\025"], '', $after); + $after = trim(str_replace(["\r", "\n", "\t", "\036", "\025"], '', $after)); + + if('' === $after) { + Log::warning('Action resulted in an empty description, reset to default value.'); + $after = '(no description)'; + } DB::table('transaction_journals') ->where('id', '=', $journal['transaction_journal_id'])