kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Clean up code.

Browse Source
This commit is contained in:
James Cole
2023-02-12 07:23:57 +01:00
parent 927d607b1a
commit 789935cf1c
67 changed files with 154 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php
View File

@@ -160,7 +160,7 @@ class UpgradeLiabilitiesEight extends Command
/**
* @param $account
* @return void
* @return int
*/
private function deleteTransactions($account): int
{
@@ -279,9 +279,9 @@ class UpgradeLiabilitiesEight extends Command
->where('transactions.account_id', $account->id)
->where('transaction_journals.transaction_type_id', $openingBalanceType->id)
->first(['transaction_journals.*']);
/** @var Transaction $source */
/** @var Transaction|null $source */
$source = $openingJournal->transactions()->where('amount', '<', 0)->first();
/** @var Transaction $dest */
/** @var Transaction|null $dest */
$dest = $openingJournal->transactions()->where('amount', '>', 0)->first();
if ($source && $dest) {
$sourceId = $source->account_id;