Clean up code.

app/Api/V1/Controllers/Controller.php

@@ -97,6 +97,7 @@ abstract class Controller extends BaseController
         // some date fields:
         $dates = ['start', 'end', 'date'];
         foreach ($dates as $field) {
+            $date = null;
             try {
                 $date = request()->query->get($field);
             } catch (BadRequestException $e) {

app/Api/V1/Controllers/Models/TransactionLinkType/DestroyController.php

@@ -28,7 +28,6 @@ use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\LinkType;
 use FireflyIII\Repositories\LinkType\LinkTypeRepositoryInterface;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Support\Http\Api\TransactionFilter;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
@@ -41,7 +40,6 @@ class DestroyController extends Controller
     use TransactionFilter;
 
     private LinkTypeRepositoryInterface $repository;
-    private UserRepositoryInterface     $userRepository;
 
     /**
      * LinkTypeController constructor.
@@ -56,7 +54,6 @@ class DestroyController extends Controller
                 /** @var User $user */
                 $user             = auth()->user();
                 $this->repository = app(LinkTypeRepositoryInterface::class);
-                $this->userRepository = app(UserRepositoryInterface::class);
                 $this->repository->setUser($user);
 
                 return $next($request);
@@ -74,7 +71,6 @@ class DestroyController extends Controller
      *
      * @return JsonResponse
      * @throws FireflyException
-
      */
     public function destroy(LinkType $linkType): JsonResponse
     {

app/Api/V2/Controllers/Controller.php

@@ -92,6 +92,7 @@ class Controller extends BaseController
 
         // some date fields:
         foreach ($dates as $field) {
+            $date = null;
             try {
                 $date = request()->query->get($field);
             } catch (BadRequestException $e) {

app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php

@@ -160,7 +160,7 @@ class UpgradeLiabilitiesEight extends Command
 
     /**
      * @param $account
-     * @return void
+     * @return int
      */
     private function deleteTransactions($account): int
     {
@@ -279,9 +279,9 @@ class UpgradeLiabilitiesEight extends Command
                                             ->where('transactions.account_id', $account->id)
                                             ->where('transaction_journals.transaction_type_id', $openingBalanceType->id)
                                             ->first(['transaction_journals.*']);
-        /** @var Transaction $source */
+        /** @var Transaction|null $source */
         $source = $openingJournal->transactions()->where('amount', '<', 0)->first();
-        /** @var Transaction $dest */
+        /** @var Transaction|null $dest */
         $dest = $openingJournal->transactions()->where('amount', '>', 0)->first();
         if ($source && $dest) {
             $sourceId           = $source->account_id;

app/Exceptions/GracefulNotFoundHandler.php

@@ -221,7 +221,7 @@ class GracefulNotFoundHandler extends ExceptionHandler
         $user         = auth()->user();
         $route        = $request->route();
         $attachmentId = (int)$route->parameter('attachment');
-        /** @var Attachment $attachment */
+        /** @var Attachment|null $attachment */
         $attachment = $user->attachments()->withTrashed()->find($attachmentId);
         if (null === $attachment) {
             Log::error(sprintf('Could not find attachment %d, so give big fat error.', $attachmentId));