kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Change scope of methods, add some notes. Prep for refactoring.

Browse Source
This commit is contained in:
James Cole
2018-08-09 16:07:33 +02:00
parent 32e58d0a60
commit 7943164375
41 changed files with 189 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/Import/JobConfigurationController.php
View File

@@ -170,7 +170,7 @@ class JobConfigurationController extends Controller
*
* @throws FireflyException
*/
private function makeConfigurator(ImportJob $importJob): JobConfigurationInterface
protected function makeConfigurator(ImportJob $importJob): JobConfigurationInterface // make object
{
$key = sprintf('import.configuration.%s', $importJob->provider);
$className = (string)config($key);

2
app/Http/Controllers/Import/JobStatusController.php
View File

@@ -231,7 +231,7 @@ class JobStatusController extends Controller
*
* @throws FireflyException
*/
private function storeTransactions(ImportJob $importJob): void
protected function storeTransactions(ImportJob $importJob): void // make object + execute
{
/** @var ImportArrayStorage $storage */
$storage = app(ImportArrayStorage::class);