kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-14 16:13:54 +00:00
Code Issues Projects Releases Wiki Activity

Change scope of methods, add some notes. Prep for refactoring.

Browse Source
This commit is contained in:
James Cole
2018-08-09 16:07:33 +02:00
parent 32e58d0a60
commit 7943164375
41 changed files with 189 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Http/Controllers/Popup/ReportController.php
View File

@@ -127,7 +127,7 @@ class ReportController extends Controller
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
private function balanceAmount(array $attributes): string
protected function balanceAmount(array $attributes): string // generate view for report.
{
$role = (int)$attributes['role'];
$budget = $this->budgetRepository->findNull((int)$attributes['budgetId']);
@@ -165,7 +165,7 @@ class ReportController extends Controller
*
* @return string
*/
private function budgetSpentAmount(array $attributes): string
protected function budgetSpentAmount(array $attributes): string // generate view for report.
{
$budget = $this->budgetRepository->findNull((int)$attributes['budgetId']);
if (null === $budget) {
@@ -189,7 +189,7 @@ class ReportController extends Controller
*
* @return string
*/
private function categoryEntry(array $attributes): string
protected function categoryEntry(array $attributes): string // generate view for report.
{
$category = $this->categoryRepository->findNull((int)$attributes['categoryId']);
@@ -215,7 +215,7 @@ class ReportController extends Controller
*
* @return string
*/
private function expenseEntry(array $attributes): string
protected function expenseEntry(array $attributes): string // generate view for report.
{
$account = $this->accountRepository->findNull((int)$attributes['accountId']);
@@ -241,7 +241,7 @@ class ReportController extends Controller
*
* @return string
*/
private function incomeEntry(array $attributes): string
protected function incomeEntry(array $attributes): string // generate view for report.
{
$account = $this->accountRepository->findNull((int)$attributes['accountId']);
@@ -267,7 +267,7 @@ class ReportController extends Controller
*
* @return array
*/
private function parseAttributes(array $attributes): array
protected function parseAttributes(array $attributes): array // parse input + return result
{
$attributes['location'] = $attributes['location'] ?? '';
$attributes['accounts'] = AccountList::routeBinder($attributes['accounts'] ?? '', new Route('get', '', []));