kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Change scope of methods, add some notes. Prep for refactoring.

Browse Source
This commit is contained in:
James Cole
2018-08-09 16:07:33 +02:00
parent 32e58d0a60
commit 7943164375
41 changed files with 189 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Http/Controllers/Rule/CreateController.php
View File

@@ -206,7 +206,7 @@ class CreateController extends Controller
*
* @return array
*/
private function getActionsForBill(Bill $bill): array
protected function getActionsForBill(Bill $bill): array // get info and augument
{
try {
$result = view(
@@ -237,7 +237,7 @@ class CreateController extends Controller
*
* @return array
*/
private function getTriggersForBill(Bill $bill): array
protected function getTriggersForBill(Bill $bill): array // get info and augument
{
$result = [];
$triggers = ['currency_is', 'amount_more', 'amount_less', 'description_contains'];

4
app/Http/Controllers/Rule/EditController.php
View File

@@ -154,7 +154,7 @@ class EditController extends Controller
*
* @return array
*/
private function getCurrentActions(Rule $rule): array
protected function getCurrentActions(Rule $rule): array // get info from object and present.
{
$index = 0;
$actions = [];
@@ -192,7 +192,7 @@ class EditController extends Controller
* @return array
*
*/
private function getCurrentTriggers(Rule $rule): array
protected function getCurrentTriggers(Rule $rule): array // get info from object and present.
{
$index = 0;
$triggers = [];

2
app/Http/Controllers/Rule/SelectController.php
View File

@@ -263,7 +263,7 @@ class SelectController extends Controller
*
* @return array
*/
private function getValidTriggerList(TestRuleFormRequest $request): array
protected function getValidTriggerList(TestRuleFormRequest $request): array // process input
{
$triggers = [];
$data = $request->get('rule_triggers');