Code cleanup.

This commit is contained in:
James Cole
2018-04-02 14:42:07 +02:00
parent f96f38b172
commit 7d02d0f762
55 changed files with 200 additions and 281 deletions

View File

@@ -162,13 +162,13 @@ class BalanceLine
return $this->getBudget()->name;
}
if (self::ROLE_DEFAULTROLE === $this->getRole()) {
return strval(trans('firefly.no_budget'));
return (string)trans('firefly.no_budget');
}
if (self::ROLE_TAGROLE === $this->getRole()) {
return strval(trans('firefly.coveredWithTags'));
return (string)trans('firefly.coveredWithTags');
}
if (self::ROLE_DIFFROLE === $this->getRole()) {
return strval(trans('firefly.leftUnbalanced'));
return (string)trans('firefly.leftUnbalanced');
}
return '';

View File

@@ -101,7 +101,7 @@ class Bill
{
$set = $this->bills->sortBy(
function (BillLine $bill) {
$active = 0 === intval($bill->getBill()->active) ? 1 : 0;
$active = 0 === (int)$bill->getBill()->active ? 1 : 0;
$name = $bill->getBill()->name;
return $active . $name;

View File

@@ -190,7 +190,7 @@ class BillLine
*/
public function isActive(): bool
{
return 1 === intval($this->bill->active);
return 1 === (int)$this->bill->active;
}
/**