kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-25 21:16:47 +00:00
Code Issues Projects Releases Wiki Activity

Run phpcs locally to make sure phpstan stays fixed. [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-01-04 07:39:16 +01:00
parent 1b97d8fd48
commit 7eaa0e16b3
164 changed files with 171 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Services/Internal/Destroy/AccountDestroyService.php
View File

@@ -30,7 +30,6 @@ use FireflyIII\Models\PiggyBank;
use FireflyIII\Models\RecurrenceTransaction;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use Illuminate\Database\Eloquent\Builder;
/**

1
app/Services/Internal/Support/AccountServiceTrait.php
View File

@@ -32,7 +32,6 @@ use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Factory\TransactionCurrencyFactory;
use FireflyIII\Factory\TransactionGroupFactory;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\Note;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionCurrency;

1
app/Services/Internal/Support/CreditRecalculateService.php
View File

@@ -32,7 +32,6 @@ use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use Illuminate\Support\Facades\Log;

2
app/Services/Internal/Support/JournalServiceTrait.php
View File

@@ -30,10 +30,8 @@ use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Factory\TagFactory;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\Note;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Repositories\Category\CategoryRepositoryInterface;

1
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@@ -33,7 +33,6 @@ use FireflyIII\Factory\CategoryFactory;
use FireflyIII\Factory\PiggyBankFactory;
use FireflyIII\Factory\TransactionCurrencyFactory;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\Note;
use FireflyIII\Models\Recurrence;
use FireflyIII\Models\RecurrenceMeta;

2
app/Services/Internal/Update/BillUpdateService.php
View File

@@ -250,7 +250,7 @@ class BillUpdateService
private function getRuleTrigger(Rule $rule, string $key): ?RuleTrigger
{
/** @var RuleTrigger|null */
/** @var null|RuleTrigger */
return $rule->ruleTriggers()->where('trigger_type', $key)->first();
}
}

10
app/Services/Internal/Update/JournalUpdateService.php
View File

@@ -35,10 +35,8 @@ use FireflyIII\Factory\TransactionJournalMetaFactory;
use FireflyIII\Factory\TransactionTypeFactory;
use FireflyIII\Models\Account;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Bill\BillRepositoryInterface;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
@@ -238,8 +236,8 @@ class JournalUpdateService
private function getSourceTransaction(): Transaction
{
if (null === $this->sourceTransaction) {
/** @var Transaction|null $result */
$result = $this->transactionJournal->transactions()->with(['account'])->where('amount', '<', 0)->first();
/** @var null|Transaction $result */
$result = $this->transactionJournal->transactions()->with(['account'])->where('amount', '<', 0)->first();
$this->sourceTransaction = $result;
}
Log::debug(sprintf('getSourceTransaction: %s', $this->sourceTransaction->amount));
@@ -319,8 +317,8 @@ class JournalUpdateService
private function getDestinationTransaction(): Transaction
{
if (null === $this->destinationTransaction) {
/** @var Transaction|null $result */
$result = $this->transactionJournal->transactions()->where('amount', '>', 0)->first();
/** @var null|Transaction $result */
$result = $this->transactionJournal->transactions()->where('amount', '>', 0)->first();
$this->destinationTransaction = $result;
}

4
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@@ -169,7 +169,7 @@ class RecurrenceUpdateService
if (1 === $originalCount) {
app('log')->debug('Return the first one');
/** @var RecurrenceRepetition|null */
/** @var null|RecurrenceRepetition */
return $recurrence->recurrenceRepetitions()->first();
}
// find it:
@@ -187,7 +187,7 @@ class RecurrenceUpdateService
}
}
/** @var RecurrenceRepetition|null */
/** @var null|RecurrenceRepetition */
return $query->first();
}