From 845eaed8d770c6fc7fd60ec733f4e931e357dbf6 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 16 Mar 2024 11:27:07 +0100 Subject: [PATCH] Code cleanup. --- app/Console/Commands/Upgrade/MigrateRuleActions.php | 5 ----- app/Transformers/V2/AccountTransformer.php | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/Console/Commands/Upgrade/MigrateRuleActions.php b/app/Console/Commands/Upgrade/MigrateRuleActions.php index 9fd065f8e1..638bcf967c 100644 --- a/app/Console/Commands/Upgrade/MigrateRuleActions.php +++ b/app/Console/Commands/Upgrade/MigrateRuleActions.php @@ -68,11 +68,6 @@ class MigrateRuleActions extends Command return false; } - private function markAsExecuted(): void - { - app('fireflyconfig')->set(self::CONFIG_NAME, true); - } - private function replaceEqualSign(): void { $count = 0; diff --git a/app/Transformers/V2/AccountTransformer.php b/app/Transformers/V2/AccountTransformer.php index 5d70603458..3dd8cd9de2 100644 --- a/app/Transformers/V2/AccountTransformer.php +++ b/app/Transformers/V2/AccountTransformer.php @@ -101,7 +101,7 @@ class AccountTransformer extends AbstractTransformer $array = Transaction::whereIn('account_id', $accountIds) ->leftJoin('transaction_journals', 'transaction_journals.id', 'transactions.transaction_journal_id') ->groupBy('transactions.account_id') - ->get(['transactions.account_id', DB::raw('MAX(transaction_journals.date) as date_max')])->toArray() + ->get(['transactions.account_id', DB::raw('MAX(transaction_journals.date) as date_max')])->toArray() // @phpstan-ignore-line ; foreach ($array as $row) { $this->lastActivity[(int)$row['account_id']] = Carbon::parse($row['date_max'], config('app.timezone'));