kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Some small code optimisations.

Browse Source
This commit is contained in:
James Cole
2015-07-09 06:13:39 +02:00
parent 0372c1aaf1
commit 84a7f825d7
7 changed files with 59 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@@ -94,15 +94,15 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
*
* set id of piggy bank.
*
* @param int $id
* @param int $piggyBankId
* @param int $order
*
* @return void
*/
public function setOrder($id, $order)
public function setOrder($piggyBankId, $order)
{
$piggyBank = PiggyBank::leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')->where('accounts.user_id', Auth::user()->id)
->where('piggy_banks.id', $id)->first(['piggy_banks.*']);
->where('piggy_banks.id', $piggyBankId)->first(['piggy_banks.*']);
if ($piggyBank) {
$piggyBank->order = $order;
$piggyBank->save();

4
app/Repositories/PiggyBank/PiggyBankRepositoryInterface.php
View File

@@ -58,12 +58,12 @@ interface PiggyBankRepositoryInterface
*
* set id of piggy bank.
*
* @param int $id
* @param int $piggyBankId
* @param int $order
*
* @return void
*/
public function setOrder($id, $order);
public function setOrder($piggyBankId, $order);
/**