Clean up code [skip ci]

tests/Api/V1/Controllers/BudgetControllerTest.php

@@ -27,16 +27,9 @@ namespace Tests\Api\V1\Controllers;
 use FireflyIII\Helpers\Collector\TransactionCollectorInterface;
 use FireflyIII\Models\Budget;
 use FireflyIII\Models\BudgetLimit;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
-use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Transformers\BudgetLimitTransformer;
 use FireflyIII\Transformers\BudgetTransformer;
-use FireflyIII\Transformers\TransactionTransformer;
-use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Tests\TestCase;

tests/Api/V1/Controllers/BudgetLimitControllerTest.php

@@ -25,17 +25,9 @@ namespace Tests\Api\V1\Controllers;
 
 
 use FireflyIII\Helpers\Collector\TransactionCollectorInterface;
-use FireflyIII\Models\Budget;
 use FireflyIII\Models\BudgetLimit;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
-use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Transformers\BudgetLimitTransformer;
-use FireflyIII\Transformers\TransactionTransformer;
-use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Tests\TestCase;

tests/Api/V1/Controllers/CategoryControllerTest.php

@@ -26,15 +26,8 @@ namespace Tests\Api\V1\Controllers;
 
 use FireflyIII\Helpers\Collector\TransactionCollectorInterface;
 use FireflyIII\Models\Category;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
-use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Transformers\CategoryTransformer;
-use FireflyIII\Transformers\TransactionTransformer;
-use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Tests\TestCase;

tests/Api/V1/Controllers/CurrencyControllerTest.php

@@ -25,36 +25,12 @@ namespace Tests\Api\V1\Controllers;
 
 
 use FireflyIII\Helpers\Collector\TransactionCollectorInterface;
-use FireflyIII\Models\AvailableBudget;
-use FireflyIII\Models\Bill;
-use FireflyIII\Models\BudgetLimit;
 use FireflyIII\Models\Preference;
-use FireflyIII\Models\Recurrence;
-use FireflyIII\Models\Rule;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Bill\BillRepositoryInterface;
-use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
-use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
-use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
-use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
-use FireflyIII\Transformers\AccountTransformer;
-use FireflyIII\Transformers\AvailableBudgetTransformer;
-use FireflyIII\Transformers\BillTransformer;
-use FireflyIII\Transformers\BudgetLimitTransformer;
-use FireflyIII\Transformers\CurrencyExchangeRateTransformer;
 use FireflyIII\Transformers\CurrencyTransformer;
-use FireflyIII\Transformers\RecurrenceTransformer;
-use FireflyIII\Transformers\RuleTransformer;
-use FireflyIII\Transformers\TransactionTransformer;
-use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
-use Mockery;
 use Preferences;
 use Tests\TestCase;
 

tests/Api/V1/Controllers/PreferencesControllerTest.php

@@ -27,7 +27,6 @@ use FireflyIII\Models\Preference;
 use FireflyIII\Transformers\PreferenceTransformer;
 use Laravel\Passport\Passport;
 use Log;
-use Mockery;
 use Preferences;
 use Tests\TestCase;
 

tests/Api/V1/Controllers/RecurrenceControllerTest.php

@@ -24,16 +24,10 @@ declare(strict_types=1);
 namespace Tests\Api\V1\Controllers;
 
 use Carbon\Carbon;
-use FireflyIII\Factory\CategoryFactory;
-use FireflyIII\Models\AccountType;
 use FireflyIII\Models\Recurrence;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
-use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
 use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
 use FireflyIII\Transformers\RecurrenceTransformer;
 use FireflyIII\Validation\AccountValidator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Tests\TestCase;
@@ -664,10 +658,10 @@ class RecurrenceControllerTest extends TestCase
                 'message' => 'The given data was invalid.',
                 'errors'  => [
                     'transactions.0.destination_id'   => [
-                        null
+                        null,
                     ],
                     'transactions.0.destination_name' => [
-                        null
+                        null,
                     ],
                 ],
             ]
@@ -1131,10 +1125,10 @@ class RecurrenceControllerTest extends TestCase
                 'message' => 'The given data was invalid.',
                 'errors'  => [
                     'transactions.0.source_id'   => [
-                        null
+                        null,
                     ],
                     'transactions.0.source_name' => [
-                        null
+                        null,
                     ],
                 ],
             ]
@@ -1204,7 +1198,7 @@ class RecurrenceControllerTest extends TestCase
                         'This value is invalid for this field.',
                     ],
                     'transactions.0.source_name' => [
-                        null
+                        null,
                     ],
                 ],
             ]

tests/Api/V1/Controllers/RuleControllerTest.php

@@ -28,7 +28,6 @@ use FireflyIII\Jobs\ExecuteRuleOnExistingTransactions;
 use FireflyIII\Jobs\Job;
 use FireflyIII\Models\Rule;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
 use FireflyIII\TransactionRules\TransactionMatcher;
 use FireflyIII\Transformers\RuleTransformer;

tests/Api/V1/Controllers/TagControllerTest.php

@@ -24,12 +24,8 @@ declare(strict_types=1);
 namespace Tests\Api\V1\Controllers;
 
 use FireflyIII\Helpers\Collector\TransactionCollectorInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Repositories\Tag\TagRepositoryInterface;
 use FireflyIII\Transformers\TagTransformer;
-use FireflyIII\Transformers\TransactionTransformer;
-use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Tests\TestCase;

tests/Api/V1/Controllers/TransactionControllerTest.php

@@ -901,6 +901,7 @@ class TransactionControllerTest extends TestCase
     public function testUpdateFailTypes(): void
     {
         $this->markTestIncomplete('Needs to be rewritten for v4.8.0');
+
         return;
         // mock data:
         $group = $this->getRandomWithdrawalGroup();
@@ -961,6 +962,7 @@ class TransactionControllerTest extends TestCase
     public function testUpdateFailWithdrawalSource(): void
     {
         $this->markTestIncomplete('Needs to be rewritten for v4.8.0');
+
         return;
         // mock data:
         $group = $this->getRandomWithdrawalGroup();
@@ -1023,6 +1025,7 @@ class TransactionControllerTest extends TestCase
     public function testUpdateOK(): void
     {
         $this->markTestIncomplete('Needs to be rewritten for v4.8.0');
+
         return;
         // mock data:
         $group = $this->getRandomWithdrawalGroup();

tests/Api/V1/Controllers/UserControllerTest.php

@@ -27,7 +27,6 @@ namespace Tests\Api\V1\Controllers;
 use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Transformers\UserTransformer;
 use FireflyIII\User;
-use Illuminate\Support\Collection;
 use Laravel\Passport\Passport;
 use Log;
 use Mockery;