kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-25 13:10:35 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-06-12 19:32:34 +02:00
parent 4614625f82
commit 85204de9aa
31 changed files with 52 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Services/Internal/Support/CreditRecalculateService.php
View File

@@ -67,7 +67,7 @@ class CreditRecalculateService
// work based on account.
$this->processAccount();
}
if (0 === count($this->work)) {
if (empty($this->work)) {
Log::debug('No work accounts, do not do CreditRecalculationService');
return;
@@ -127,7 +127,7 @@ class CreditRecalculateService
{
/** @var TransactionJournal $journal */
foreach ($this->group->transactionJournals as $journal) {
if (0 === count($this->work)) {
if (empty($this->work)) {
try {
$this->findByJournal($journal);
} catch (FireflyException $e) {

2
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@@ -322,7 +322,7 @@ trait RecurringTransactionTrait
$entry->value = json_encode($tags);
$entry->save();
}
if (0 === count($tags)) {
if (empty($tags)) {
// delete if present
$transaction->recurrenceTransactionMeta()->where('name', 'tags')->delete();
}

2
app/Services/Internal/Update/GroupUpdateService.php
View File

@@ -57,7 +57,7 @@ class GroupUpdateService
$transactionGroup->save();
}
if (0 === count($transactions)) {
if (empty($transactions)) {
Log::debug('No transactions submitted, do nothing.');
return $transactionGroup;

4
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@@ -149,7 +149,7 @@ class RecurrenceUpdateService
private function updateRepetitions(Recurrence $recurrence, array $repetitions): void
{
$originalCount = $recurrence->recurrenceRepetitions()->count();
if (0 === count($repetitions)) {
if (empty($repetitions)) {
// wont drop repetition, rather avoid.
return;
}
@@ -227,7 +227,7 @@ class RecurrenceUpdateService
private function updateTransactions(Recurrence $recurrence, array $transactions): void
{
$originalCount = $recurrence->recurrenceTransactions()->count();
if (0 === count($transactions)) {
if (empty($transactions)) {
// wont drop transactions, rather avoid.
return;
}