mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-10-25 13:10:35 +00:00
Remove TODO's.
This commit is contained in:
@@ -102,7 +102,7 @@ trait AccountServiceTrait
|
||||
/**
|
||||
* Update meta data for account. Depends on type which fields are valid.
|
||||
*
|
||||
* TODO this method treats expense accounts and liabilities the same way (tries to save interest)
|
||||
* See reference nr. 97
|
||||
*
|
||||
* @param Account $account
|
||||
* @param array $data
|
||||
@@ -410,7 +410,7 @@ trait AccountServiceTrait
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO rename to "getOpposingTransaction"
|
||||
* See reference nr. 98
|
||||
*
|
||||
* @param TransactionJournal $journal
|
||||
* @param Account $account
|
||||
@@ -705,7 +705,7 @@ trait AccountServiceTrait
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO Refactor to "getFirstJournal"
|
||||
* See reference nr. 99
|
||||
*
|
||||
* @param TransactionGroup $group
|
||||
*
|
||||
|
||||
@@ -145,7 +145,7 @@ trait RecurringTransactionTrait
|
||||
if (array_key_exists('foreign_amount', $array) && '' === (string)$array['foreign_amount']) {
|
||||
unset($array['foreign_amount']);
|
||||
}
|
||||
// TODO typeOverrule: the account validator may have another opinion on the transaction type.
|
||||
// See reference nr. 100
|
||||
$transaction = new RecurrenceTransaction(
|
||||
[
|
||||
'recurrence_id' => $recurrence->id,
|
||||
|
||||
@@ -35,7 +35,7 @@ use Log;
|
||||
|
||||
/**
|
||||
* Class AccountUpdateService
|
||||
* TODO this is a mess.
|
||||
* See reference nr. 90
|
||||
*/
|
||||
class AccountUpdateService
|
||||
{
|
||||
|
||||
@@ -35,7 +35,7 @@ use FireflyIII\Models\TransactionJournalMeta;
|
||||
|
||||
/**
|
||||
* Class GroupCloneService
|
||||
* TODO test.
|
||||
* See reference nr. 92
|
||||
*/
|
||||
class GroupCloneService
|
||||
{
|
||||
|
||||
@@ -32,7 +32,7 @@ use Log;
|
||||
|
||||
/**
|
||||
* Class GroupUpdateService
|
||||
* TODO test.
|
||||
* See reference nr. 91
|
||||
*/
|
||||
class GroupUpdateService
|
||||
{
|
||||
|
||||
@@ -48,7 +48,7 @@ use Log;
|
||||
* Class to centralise code that updates a journal given the input by system.
|
||||
*
|
||||
* Class JournalUpdateService
|
||||
* TODO test me
|
||||
* See reference nr. 93
|
||||
*/
|
||||
class JournalUpdateService
|
||||
{
|
||||
@@ -158,7 +158,7 @@ class JournalUpdateService
|
||||
$this->updateAmount();
|
||||
$this->updateForeignAmount();
|
||||
|
||||
// TODO update hash
|
||||
// See reference nr. 94
|
||||
|
||||
app('preferences')->mark();
|
||||
|
||||
@@ -201,7 +201,7 @@ class JournalUpdateService
|
||||
$result = $validator->validateSource($sourceId, $sourceName, null);
|
||||
Log::debug(sprintf('hasValidSourceAccount(%d, "%s") will return %s', $sourceId, $sourceName, var_export($result, true)));
|
||||
|
||||
// TODO typeOverrule: the account validator may have another opinion on the transaction type.
|
||||
// See reference nr. 95
|
||||
|
||||
// validate submitted info:
|
||||
return $result;
|
||||
@@ -295,7 +295,7 @@ class JournalUpdateService
|
||||
$result = $validator->validateDestination($destId, $destName, null);
|
||||
Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true)));
|
||||
|
||||
// TODO typeOverrule: the account validator may have another opinion on the transaction type.
|
||||
// See reference nr. 96
|
||||
|
||||
// validate submitted info:
|
||||
return $result;
|
||||
|
||||
@@ -49,7 +49,7 @@ class RecurrenceUpdateService
|
||||
/**
|
||||
* Updates a recurrence.
|
||||
*
|
||||
* TODO if the user updates the type, accounts must be validated (again).
|
||||
* See reference nr. 88
|
||||
*
|
||||
* @param Recurrence $recurrence
|
||||
* @param array $data
|
||||
@@ -217,7 +217,7 @@ class RecurrenceUpdateService
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO this method is way too complex.
|
||||
* See reference nr. 89
|
||||
*
|
||||
* @param Recurrence $recurrence
|
||||
* @param array $transactions
|
||||
|
||||
Reference in New Issue
Block a user