mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-10-12 15:35:15 +00:00
Fix #10827
This commit is contained in:
@@ -126,4 +126,6 @@ class ShowController extends Controller
|
|||||||
|
|
||||||
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
|
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
}
|
}
|
||||||
|
125
app/Api/V1/Controllers/Models/Recurrence/TriggerController.php
Normal file
125
app/Api/V1/Controllers/Models/Recurrence/TriggerController.php
Normal file
@@ -0,0 +1,125 @@
|
|||||||
|
<?php
|
||||||
|
/*
|
||||||
|
* TriggerController.php
|
||||||
|
* Copyright (c) 2025 james@firefly-iii.org
|
||||||
|
*
|
||||||
|
* This file is part of Firefly III (https://github.com/firefly-iii).
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU Affero General Public License as
|
||||||
|
* published by the Free Software Foundation, either version 3 of the
|
||||||
|
* License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU Affero General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU Affero General Public License
|
||||||
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||||
|
*/
|
||||||
|
|
||||||
|
namespace FireflyIII\Api\V1\Controllers\Models\Recurrence;
|
||||||
|
|
||||||
|
use FireflyIII\Api\V1\Controllers\Controller;
|
||||||
|
use FireflyIII\Api\V1\Requests\Generic\SingleDateRequest;
|
||||||
|
use FireflyIII\Helpers\Collector\GroupCollectorInterface;
|
||||||
|
use FireflyIII\Jobs\CreateRecurringTransactions;
|
||||||
|
use FireflyIII\Models\Recurrence;
|
||||||
|
use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
|
||||||
|
use FireflyIII\Support\Facades\Preferences;
|
||||||
|
use FireflyIII\Support\JsonApi\Enrichments\TransactionGroupEnrichment;
|
||||||
|
use FireflyIII\Transformers\TransactionGroupTransformer;
|
||||||
|
use FireflyIII\User;
|
||||||
|
use Illuminate\Http\JsonResponse;
|
||||||
|
use Illuminate\Pagination\LengthAwarePaginator;
|
||||||
|
use Illuminate\Support\Collection;
|
||||||
|
use Illuminate\Support\Facades\Log;
|
||||||
|
use League\Fractal\Pagination\IlluminatePaginatorAdapter;
|
||||||
|
use League\Fractal\Resource\Collection as FractalCollection;
|
||||||
|
|
||||||
|
class TriggerController extends Controller
|
||||||
|
{
|
||||||
|
private RecurringRepositoryInterface $repository;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* RecurrenceController constructor.
|
||||||
|
*/
|
||||||
|
public function __construct()
|
||||||
|
{
|
||||||
|
parent::__construct();
|
||||||
|
$this->middleware(
|
||||||
|
function ($request, $next) {
|
||||||
|
$this->repository = app(RecurringRepositoryInterface::class);
|
||||||
|
$this->repository->setUser(auth()->user());
|
||||||
|
|
||||||
|
return $next($request);
|
||||||
|
}
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
*/
|
||||||
|
public function trigger(SingleDateRequest $request, Recurrence $recurrence): JsonResponse
|
||||||
|
{
|
||||||
|
// find recurrence occurrence for this date and trigger it.
|
||||||
|
// grab the date from the last time the recurrence fired:
|
||||||
|
$backupDate = $recurrence->latest_date;
|
||||||
|
$date = $request->getDate();
|
||||||
|
|
||||||
|
// fire the recurring cron job on the given date, then post-date the created transaction.
|
||||||
|
Log::info(sprintf('Trigger: will now fire recurring cron job task for date "%s".', $date->format('Y-m-d H:i:s')));
|
||||||
|
|
||||||
|
/** @var CreateRecurringTransactions $job */
|
||||||
|
$job = app(CreateRecurringTransactions::class);
|
||||||
|
$job->setRecurrences(new Collection()->push($recurrence));
|
||||||
|
$job->setDate($date);
|
||||||
|
$job->setForce(false);
|
||||||
|
$job->handle();
|
||||||
|
Log::debug('Done with recurrence.');
|
||||||
|
|
||||||
|
$groups = $job->getGroups();
|
||||||
|
$this->repository->markGroupsAsNow($groups);
|
||||||
|
$recurrence->latest_date = $backupDate;
|
||||||
|
$recurrence->latest_date_tz = $backupDate?->format('e');
|
||||||
|
$recurrence->save();
|
||||||
|
Preferences::mark();
|
||||||
|
|
||||||
|
// enrich groups and return them:
|
||||||
|
|
||||||
|
if (0 === $groups->count()) {
|
||||||
|
$paginator = new LengthAwarePaginator(new Collection(), 0, 1,);
|
||||||
|
}
|
||||||
|
if ($groups->count() > 0) {
|
||||||
|
/** @var User $admin */
|
||||||
|
$admin = auth()->user();
|
||||||
|
// use new group collector:
|
||||||
|
/** @var GroupCollectorInterface $collector */
|
||||||
|
$collector = app(GroupCollectorInterface::class);
|
||||||
|
$collector
|
||||||
|
->setUser($admin)
|
||||||
|
->setIds($groups->pluck('id')->toArray())
|
||||||
|
->withAPIInformation();
|
||||||
|
$paginator = $collector->getPaginatedGroups();
|
||||||
|
}
|
||||||
|
|
||||||
|
$manager = $this->getManager();
|
||||||
|
$paginator->setPath(route('api.v1.recurrences.trigger', [$recurrence->id]) . $this->buildParams());
|
||||||
|
|
||||||
|
// enrich
|
||||||
|
$admin = auth()->user();
|
||||||
|
$enrichment = new TransactionGroupEnrichment();
|
||||||
|
$enrichment->setUser($admin);
|
||||||
|
$transactions = $enrichment->enrich($paginator->getCollection());
|
||||||
|
|
||||||
|
/** @var TransactionGroupTransformer $transformer */
|
||||||
|
$transformer = app(TransactionGroupTransformer::class);
|
||||||
|
$transformer->setParameters($this->parameters);
|
||||||
|
|
||||||
|
$resource = new FractalCollection($transactions, $transformer, 'transactions');
|
||||||
|
$resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
|
||||||
|
|
||||||
|
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
@@ -861,8 +861,8 @@ class GroupCollector implements GroupCollectorInterface
|
|||||||
|
|
||||||
return new LengthAwarePaginator($set, $this->total, $total, 1);
|
return new LengthAwarePaginator($set, $this->total, $total, 1);
|
||||||
}
|
}
|
||||||
|
$limit= $this->limit ?? 1;
|
||||||
return new LengthAwarePaginator($set, $this->total, $this->limit, $this->page);
|
return new LengthAwarePaginator($set, $this->total, $limit, $this->page);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -28,8 +28,7 @@ use FireflyIII\Http\Controllers\Controller;
|
|||||||
use FireflyIII\Http\Requests\TriggerRecurrenceRequest;
|
use FireflyIII\Http\Requests\TriggerRecurrenceRequest;
|
||||||
use FireflyIII\Jobs\CreateRecurringTransactions;
|
use FireflyIII\Jobs\CreateRecurringTransactions;
|
||||||
use FireflyIII\Models\Recurrence;
|
use FireflyIII\Models\Recurrence;
|
||||||
use FireflyIII\Models\TransactionGroup;
|
use FireflyIII\Support\Facades\Preferences;
|
||||||
use FireflyIII\Models\TransactionJournal;
|
|
||||||
use Illuminate\Http\RedirectResponse;
|
use Illuminate\Http\RedirectResponse;
|
||||||
use Illuminate\Support\Collection;
|
use Illuminate\Support\Collection;
|
||||||
|
|
||||||
@@ -58,20 +57,11 @@ class TriggerController extends Controller
|
|||||||
app('log')->debug('Done with recurrence.');
|
app('log')->debug('Done with recurrence.');
|
||||||
|
|
||||||
$groups = $job->getGroups();
|
$groups = $job->getGroups();
|
||||||
|
$this->repository->markGroupsAsNow($groups);
|
||||||
/** @var TransactionGroup $group */
|
|
||||||
foreach ($groups as $group) {
|
|
||||||
/** @var TransactionJournal $journal */
|
|
||||||
foreach ($group->transactionJournals as $journal) {
|
|
||||||
app('log')->debug(sprintf('Set date of journal #%d to today!', $journal->id));
|
|
||||||
$journal->date = today(config('app.timezone'));
|
|
||||||
$journal->save();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
$recurrence->latest_date = $backupDate;
|
$recurrence->latest_date = $backupDate;
|
||||||
$recurrence->latest_date_tz = $backupDate?->format('e');
|
$recurrence->latest_date_tz = $backupDate?->format('e');
|
||||||
$recurrence->save();
|
$recurrence->save();
|
||||||
app('preferences')->mark();
|
Preferences::mark();
|
||||||
|
|
||||||
if (0 === $groups->count()) {
|
if (0 === $groups->count()) {
|
||||||
$request->session()->flash('info', (string) trans('firefly.no_new_transaction_in_recurrence'));
|
$request->session()->flash('info', (string) trans('firefly.no_new_transaction_in_recurrence'));
|
||||||
|
@@ -35,6 +35,7 @@ use FireflyIII\Models\RecurrenceMeta;
|
|||||||
use FireflyIII\Models\RecurrenceRepetition;
|
use FireflyIII\Models\RecurrenceRepetition;
|
||||||
use FireflyIII\Models\RecurrenceTransaction;
|
use FireflyIII\Models\RecurrenceTransaction;
|
||||||
use FireflyIII\Models\RecurrenceTransactionMeta;
|
use FireflyIII\Models\RecurrenceTransactionMeta;
|
||||||
|
use FireflyIII\Models\TransactionGroup;
|
||||||
use FireflyIII\Models\TransactionJournal;
|
use FireflyIII\Models\TransactionJournal;
|
||||||
use FireflyIII\Models\TransactionJournalMeta;
|
use FireflyIII\Models\TransactionJournalMeta;
|
||||||
use FireflyIII\Services\Internal\Destroy\RecurrenceDestroyService;
|
use FireflyIII\Services\Internal\Destroy\RecurrenceDestroyService;
|
||||||
@@ -582,4 +583,17 @@ class RecurringRepository implements RecurringRepositoryInterface, UserGroupInte
|
|||||||
|
|
||||||
return $service->update($recurrence, $data);
|
return $service->update($recurrence, $data);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function markGroupsAsNow(Collection $groups): void
|
||||||
|
{
|
||||||
|
/** @var TransactionGroup $group */
|
||||||
|
foreach ($groups as $group) {
|
||||||
|
/** @var TransactionJournal $journal */
|
||||||
|
foreach ($group->transactionJournals as $journal) {
|
||||||
|
Log::debug(sprintf('Set date of journal #%d to today!', $journal->id));
|
||||||
|
$journal->date = now(config('app.timezone'));
|
||||||
|
$journal->save();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
@@ -139,6 +139,8 @@ interface RecurringRepositoryInterface
|
|||||||
*/
|
*/
|
||||||
public function getXOccurrencesSince(RecurrenceRepetition $repetition, Carbon $date, Carbon $afterDate, int $count): array;
|
public function getXOccurrencesSince(RecurrenceRepetition $repetition, Carbon $date, Carbon $afterDate, int $count): array;
|
||||||
|
|
||||||
|
public function markGroupsAsNow(Collection $groups): void;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Parse the repetition in a string that is user readable.
|
* Parse the repetition in a string that is user readable.
|
||||||
*/
|
*/
|
||||||
|
@@ -36,6 +36,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
|
|||||||
- [Issue 10806](https://github.com/firefly-iii/firefly-iii/issues/10806) (API: `/v1/chart/balance/balance` has undocumented `period` parameter) reported by @dreautall
|
- [Issue 10806](https://github.com/firefly-iii/firefly-iii/issues/10806) (API: `/v1/chart/balance/balance` has undocumented `period` parameter) reported by @dreautall
|
||||||
- [Issue 10807](https://github.com/firefly-iii/firefly-iii/issues/10807) (API: `/v1/bills` field `object_group_id` returns int, should be string) reported by @dreautall
|
- [Issue 10807](https://github.com/firefly-iii/firefly-iii/issues/10807) (API: `/v1/bills` field `object_group_id` returns int, should be string) reported by @dreautall
|
||||||
- [Issue 10815](https://github.com/firefly-iii/firefly-iii/issues/10815) (API: `/v1/accounts` balance is off by a day) reported by @dreautall
|
- [Issue 10815](https://github.com/firefly-iii/firefly-iii/issues/10815) (API: `/v1/accounts` balance is off by a day) reported by @dreautall
|
||||||
|
- #10827
|
||||||
|
|
||||||
## 6.3.2 - 2025-08-20
|
## 6.3.2 - 2025-08-20
|
||||||
|
|
||||||
|
@@ -505,6 +505,7 @@ Route::group(
|
|||||||
Route::get('', ['uses' => 'ShowController@index', 'as' => 'index']);
|
Route::get('', ['uses' => 'ShowController@index', 'as' => 'index']);
|
||||||
Route::post('', ['uses' => 'StoreController@store', 'as' => 'store']);
|
Route::post('', ['uses' => 'StoreController@store', 'as' => 'store']);
|
||||||
Route::get( '{recurrence}', ['uses' => 'ShowController@show', 'as' => 'show']);
|
Route::get( '{recurrence}', ['uses' => 'ShowController@show', 'as' => 'show']);
|
||||||
|
Route::post('{recurrence}/trigger', ['uses' => 'TriggerController@trigger', 'as' => 'trigger']);
|
||||||
Route::put('{recurrence}', ['uses' => 'UpdateController@update', 'as' => 'update']);
|
Route::put('{recurrence}', ['uses' => 'UpdateController@update', 'as' => 'update']);
|
||||||
Route::delete('{recurrence}', ['uses' => 'DestroyController@destroy', 'as' => 'delete']);
|
Route::delete('{recurrence}', ['uses' => 'DestroyController@destroy', 'as' => 'delete']);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user