Various code cleanup and phpstan suggestions

2025-09-21 03:39:00 +00:00 · 2022-11-02 06:25:37 +01:00
parent 74610a5d55
commit 8d8f81c27d
45 changed files with 147 additions and 27 deletions
--- a/app/Http/Controllers/Json/FrontpageController.php
+++ b/app/Http/Controllers/Json/FrontpageController.php
@@ -22,6 +22,7 @@ declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Json;

+use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Models\PiggyBank;
 use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
@@ -73,6 +74,7 @@ class FrontpageController extends Controller
            } catch (Throwable $e) {
                Log::error(sprintf('Cannot render json.piggy-banks: %s', $e->getMessage()));
                $html = 'Could not render view.';
+                throw new FireflyException($html, 0, $e);
            }
        }