Code cleanup.

This commit is contained in:
James Cole
2017-04-09 07:56:46 +02:00
parent 595596d73f
commit 8db96025a3
81 changed files with 228 additions and 276 deletions

View File

@@ -25,11 +25,6 @@ body.waiting * {
cursor: progress;
}
.ui-sortable-placeholder {
display: inline-block;
height: 1px;
}
.preferences-box {
border: 1px #ddd solid;
border-radius: 4px 4px 0 0;
@@ -48,12 +43,6 @@ body.waiting * {
margin: 20px auto 0 auto;
}
.ff-error-page > .headline {
float: left;
font-size: 100px;
font-weight: 300;
}
.ff-error-page > .error-content {
margin-left: 190px;
display: block;

View File

@@ -15,7 +15,7 @@ $(function () {
if (budgetLimitID > 0) {
lineChart(budgetChartUri, 'budgetOverview');
}
if (budgetLimitID == 0) {
if (budgetLimitID === 0) {
columnChart(budgetChartUri, 'budgetOverview');
}

View File

@@ -12,5 +12,5 @@
$(function () {
"use strict";
columnChart(specific, 'period-specific-period');
columnChart(specific, 'period-specific-period');
});

View File

@@ -62,7 +62,7 @@ function updateBar(data) {
function reportErrors(data) {
"use strict";
if (data.errors.length == 1) {
if (data.errors.length === 1) {
$('#import-status-error-intro').text(langImportSingleError);
//'An error has occured during the import. The import can continue, however.'
}
@@ -93,7 +93,7 @@ function kickStartJob() {
function updateTimeout(data) {
"use strict";
if (data.stepsDone != stepCount) {
if (data.stepsDone !== stepCount) {
stepCount = data.stepsDone;
currentLimit = 0;
return;

View File

@@ -14,7 +14,7 @@ $(function () {
"use strict";
// do chart JS stuff.
drawChart();
if (showTour == true) {
if (showTour === true) {
$.getJSON('json/tour').done(function (data) {
var tour = new Tour(
{

View File

@@ -99,9 +99,9 @@ function displayAjaxPartial(data, holder) {
function failAjaxPartial(uri, holder) {
"use strict";
var holder = $('#' + holder);
holder.parent().find('.overlay').remove();
holder.addClass('general-chart-error');
var holderObject = $('#' + holder);
holderObject.parent().find('.overlay').remove();
holderObject.addClass('general-chart-error');
}

View File

@@ -16,7 +16,7 @@ $(function () {
loadAjaxPartial('categoryReport', categoryReportUri);
loadAjaxPartial('budgetReport', budgetReportUri);
loadAjaxPartial('balanceReport',balanceReportUri);
loadAjaxPartial('balanceReport', balanceReportUri);
});
function drawChart() {

View File

@@ -56,7 +56,7 @@ $(function () {
// set date from cookie
var startStr = readCookie('report-start');
var endStr = readCookie('report-end');
if (startStr !== null && endStr !== null && startStr.length == 8 && endStr.length == 8) {
if (startStr !== null && endStr !== null && startStr.length === 8 && endStr.length === 8) {
var startDate = moment(startStr, "YYYY-MM-DD");
var endDate = moment(endStr, "YYYY-MM-DD");
var datePicker = $('#inputDateRange').data('daterangepicker');

View File

@@ -104,14 +104,14 @@ function addNewAction() {
function removeTrigger(e) {
"use strict";
var target = $(e.target);
if (target.prop("tagName") == "I") {
if (target.prop("tagName") === "I") {
target = target.parent();
}
// remove grand parent:
target.parent().parent().remove();
// if now at zero, immediatly add one again:
if ($('.rule-trigger-tbody tr').length == 0) {
if ($('.rule-trigger-tbody tr').length === 0) {
addNewTrigger();
}
return false;
@@ -125,14 +125,14 @@ function removeTrigger(e) {
function removeAction(e) {
"use strict";
var target = $(e.target);
if (target.prop("tagName") == "I") {
if (target.prop("tagName") === "I") {
target = target.parent();
}
// remove grand parent:
target.parent().parent().remove();
// if now at zero, immediatly add one again:
if ($('.rule-action-tbody tr').length == 0) {
if ($('.rule-action-tbody tr').length === 0) {
addNewAction();
}
return false;

View File

@@ -51,28 +51,28 @@ function clearLocation() {
function initialize() {
"use strict";
/*
Create new map:
Create new map:
*/
map = new google.maps.Map(document.getElementById('map-canvas'), mapOptions);
/*
Respond to click event.
Respond to click event.
*/
google.maps.event.addListener(map, 'rightclick', function (event) {
placeMarker(event);
});
/*
Respond to zoom event.
Respond to zoom event.
*/
google.maps.event.addListener(map, 'zoom_changed', function () {
saveZoomLevel();
});
/*
Maybe place marker?
Maybe place marker?
*/
if(doPlaceMarker == true) {
var myLatlng = new google.maps.LatLng(latitude,longitude);
if (doPlaceMarker === true) {
var myLatlng = new google.maps.LatLng(latitude, longitude);
var fakeEvent = {};
fakeEvent.latLng = myLatlng;
placeMarker(fakeEvent);

View File

@@ -72,8 +72,8 @@ function countChecked() {
"use strict";
var checked = $('.select_all_single:checked').length;
if (checked > 0) {
$('.mass_edit span').text(edit_selected_txt + ' (' + checked + ')')
$('.mass_delete span').text(delete_selected_txt + ' (' + checked + ')')
$('.mass_edit span').text(edit_selected_txt + ' (' + checked + ')');
$('.mass_delete span').text(delete_selected_txt + ' (' + checked + ')');
$('.mass_button_options').show();
} else {

View File

@@ -26,7 +26,7 @@ $(document).ready(function () {
}
// update currency
$('select[name="source_account_id"]').on('change', updateCurrency)
$('select[name="source_account_id"]').on('change', updateCurrency);
// get JSON things:
getJSONautocomplete();
@@ -178,7 +178,7 @@ function updateButtons() {
// new click event:
button.bind('click', clickButton);
if (button.data('what') == what) {
if (button.data('what') === what) {
button.removeClass('btn-default').addClass('btn-info').html('<i class="fa fa-fw fa-check"></i> ' + txt[button.data('what')]);
} else {
button.removeClass('btn-info').addClass('btn-default').text(txt[button.data('what')]);
@@ -190,7 +190,7 @@ function clickButton(e) {
"use strict";
var button = $(e.target);
var newWhat = button.data('what');
if (newWhat != what) {
if (newWhat !== what) {
what = newWhat;
updateButtons();
updateForm();

View File

@@ -184,12 +184,12 @@ function calculateSum() {
var set = $('input[name$="][amount]"]');
for (var i = 0; i < set.length; i++) {
var current = $(set[i]);
sum += (current.val() == "" ? 0 : parseFloat(current.val()));
sum += (current.val() === "" ? 0 : parseFloat(current.val()));
}
sum = Math.round(sum * 100) / 100;
$('.amount-warning').remove();
if (sum != originalSum) {
if (sum !== originalSum) {
var holder = $('#journal_amount_holder');
var par = holder.find('p.form-control-static');
$('<span>').text(' (' + accounting.formatMoney(sum) + ')').addClass('text-danger amount-warning').appendTo(par);