kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Validate amount

Browse Source
This commit is contained in:
James Cole
2022-04-09 07:05:31 +02:00
parent f033a14bc7
commit 8eb4c64602
2 changed files with 280 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@@ -261,6 +261,12 @@ trait ModifiesPiggyBanks
$piggyData = $data;
// unset fields just in case.
unset($piggyData['object_group_title'], $piggyData['object_group_id'], $piggyData['notes'], $piggyData['current_amount']);
// validate amount:
if (array_key_exists('targetamount', $data) && '' === (string) $data['targetamount']) {
$data['targetamount'] = '0';
}
try {
/** @var PiggyBank $piggyBank */
$piggyBank = PiggyBank::create($piggyData);
@@ -403,7 +409,7 @@ trait ModifiesPiggyBanks
// if the piggy bank is now smaller than the current relevant rep,
// remove money from the rep.
$repetition = $this->getRepetition($piggyBank);
if (null !== $repetition && $repetition->currentamount > $piggyBank->targetamount && 0.0 !== (float)$piggyBank->targetamount) {
if (null !== $repetition && $repetition->currentamount > $piggyBank->targetamount && 0.0 !== (float) $piggyBank->targetamount) {
$diff = bcsub($piggyBank->targetamount, $repetition->currentamount);
$this->createEvent($piggyBank, $diff);