Fix possible null pointer.

2025-11-19 16:10:00 +00:00 · 2018-03-30 22:40:20 +02:00
parent 08ff3d8ad0
commit 8f3e84df4d
16 changed files with 437 additions and 35 deletions
--- a/tests/Unit/Handlers/Events/VersionCheckEventHandlerTest.php
+++ b/tests/Unit/Handlers/Events/VersionCheckEventHandlerTest.php
@@ -0,0 +1,172 @@
+<?php
+/**
+ * VersionCheckEventHandlerTest.php
+ * Copyright (c) 2018 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Handlers\Events;
+
+
+use FireflyConfig;
+use FireflyIII\Events\RequestedVersionCheckStatus;
+use FireflyIII\Exceptions\FireflyException;
+use FireflyIII\Handlers\Events\VersionCheckEventHandler;
+use FireflyIII\Models\Configuration;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
+use FireflyIII\Services\Github\Object\Release;
+use FireflyIII\Services\Github\Request\UpdateRequest;
+use Mockery;
+use Tests\TestCase;
+
+/**
+ * Class VersionCheckEventHandlerTest
+ */
+class VersionCheckEventHandlerTest extends TestCase
+{
+    /**
+     *
+     */
+    public function testCheckForUpdatesError()
+    {
+        $updateConfig       = new Configuration;
+        $updateConfig->data = 1;
+        $checkConfig        = new Configuration;
+        $checkConfig->data  = time() - 604810;
+
+
+        $event   = new RequestedVersionCheckStatus($this->user());
+        $request = $this->mock(UpdateRequest::class);
+        $repos   = $this->mock(UserRepositoryInterface::class);
+        $repos->shouldReceive('hasRole')->andReturn(true)->once();
+
+        // report on config variables:
+        FireflyConfig::shouldReceive('get')->withArgs(['permission_update_check', -1])->once()->andReturn($updateConfig);
+        FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
+
+        // request thing:
+        $request->shouldReceive('call')->once();
+        $request->shouldReceive('getReleases')->once()->andThrow(new FireflyException('Errrr'));
+
+
+        $handler = new VersionCheckEventHandler;
+        $handler->checkForUpdates($event);
+    }
+
+    /**
+     * @covers \FireflyIII\Events\RequestedVersionCheckStatus
+     * @covers \FireflyIII\Handlers\Events\VersionCheckEventHandler
+     */
+    public function testCheckForUpdatesNewer()
+    {
+        $updateConfig       = new Configuration;
+        $updateConfig->data = 1;
+        $checkConfig        = new Configuration;
+        $checkConfig->data  = time() - 604800;
+
+
+        $event   = new RequestedVersionCheckStatus($this->user());
+        $request = $this->mock(UpdateRequest::class);
+        $repos   = $this->mock(UserRepositoryInterface::class);
+        $repos->shouldReceive('hasRole')->andReturn(true)->once();
+
+        // is newer than default return:
+        $version = config('firefly.version');
+        $first   = new Release(['id' => '1', 'title' => $version . '.1', 'updated' => '2017-05-01', 'content' => '']);
+        // report on config variables:
+        FireflyConfig::shouldReceive('get')->withArgs(['permission_update_check', -1])->once()->andReturn($updateConfig);
+        FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
+        FireflyConfig::shouldReceive('set')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
+
+        // request thing:
+        $request->shouldReceive('call')->once();
+        $request->shouldReceive('getReleases')->once()->andReturn([$first]);
+
+
+        $handler = new VersionCheckEventHandler;
+        $handler->checkForUpdates($event);
+    }
+
+    /**
+     *
+     */
+    public function testCheckForUpdatesNoAdmin()
+    {
+        $updateConfig       = new Configuration;
+        $updateConfig->data = 1;
+        $checkConfig        = new Configuration;
+        $checkConfig->data  = time() - 604800;
+
+
+        $event = new RequestedVersionCheckStatus($this->user());
+        $repos = $this->mock(UserRepositoryInterface::class);
+        $repos->shouldReceive('hasRole')->andReturn(false)->once();
+
+        $handler = new VersionCheckEventHandler;
+        $handler->checkForUpdates($event);
+    }
+
+    /**
+     *
+     */
+    public function testCheckForUpdatesNoPermission()
+    {
+        $updateConfig       = new Configuration;
+        $updateConfig->data = -1;
+        $checkConfig        = new Configuration;
+        $checkConfig->data  = time() - 604800;
+
+
+        $event = new RequestedVersionCheckStatus($this->user());
+        $repos = $this->mock(UserRepositoryInterface::class);
+        $repos->shouldReceive('hasRole')->andReturn(true)->once();
+
+        // report on config variables:
+        FireflyConfig::shouldReceive('get')->withArgs(['permission_update_check', -1])->once()->andReturn($updateConfig);
+        FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
+
+        $handler = new VersionCheckEventHandler;
+        $handler->checkForUpdates($event);
+    }
+
+    /**
+     *
+     */
+    public function testCheckForUpdatesTooRecent()
+    {
+        $updateConfig       = new Configuration;
+        $updateConfig->data = 1;
+        $checkConfig        = new Configuration;
+        $checkConfig->data  = time() - 800;
+
+
+        $event = new RequestedVersionCheckStatus($this->user());
+        $repos = $this->mock(UserRepositoryInterface::class);
+        $repos->shouldReceive('hasRole')->andReturn(true)->once();
+
+
+        // report on config variables:
+        FireflyConfig::shouldReceive('get')->withArgs(['permission_update_check', -1])->once()->andReturn($updateConfig);
+        FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
+
+        $handler = new VersionCheckEventHandler;
+        $handler->checkForUpdates($event);
+    }
+
+}