From 935634e487ec3bfad8816057e0336c5f2317d282 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 6 Jan 2024 14:23:20 +0100 Subject: [PATCH] Sanity check on number. --- app/Http/Controllers/Budget/BudgetLimitController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/Budget/BudgetLimitController.php b/app/Http/Controllers/Budget/BudgetLimitController.php index 7eade3fe56..a293e25fae 100644 --- a/app/Http/Controllers/Budget/BudgetLimitController.php +++ b/app/Http/Controllers/Budget/BudgetLimitController.php @@ -202,7 +202,9 @@ class BudgetLimitController extends Controller if ('' === $amount) { $amount = '0'; } - + if ((int)$amount > 268435456) { // 268 million, intentional integer + $amount = '268435456'; + } // sanity check on amount: if (0 === bccomp($amount, '0')) { $budgetId = $budgetLimit->budget_id; @@ -217,9 +219,7 @@ class BudgetLimitController extends Controller return response()->json($array); } - if ((int)$amount > 268435456) { // 268 million, intentional integer - $amount = '268435456'; - } + if (-1 === bccomp($amount, '0')) { $amount = bcmul($amount, '-1'); }