From 7105d34fb3245b63ea44bb24ced54f9384ccc01d Mon Sep 17 00:00:00 2001 From: Florian Dupret Date: Thu, 4 Jun 2020 08:32:17 +0200 Subject: [PATCH 1/2] Fix wrong reconciliation difference with "select all" button --- public/v1/js/ff/accounts/reconcile.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/public/v1/js/ff/accounts/reconcile.js b/public/v1/js/ff/accounts/reconcile.js index 45aafed7ed..354aacefae 100644 --- a/public/v1/js/ff/accounts/reconcile.js +++ b/public/v1/js/ff/accounts/reconcile.js @@ -90,6 +90,10 @@ function selectAllReconcile(e) { var identifier = 'checked_' + journalId; console.log('in selectAllReconcile(' + journalId + ') with amount ' + amount + ' and selected amount ' + selectedAmount); + // do nothing if line is already in target state + if (check.prop('checked') === doCheck ) + return; + check.prop('checked', doCheck); // if checked, add to selected amount if (doCheck === true && check.data('younger') === false) { From e93292d98cb9a0b901f3d9905661a73b176606db Mon Sep 17 00:00:00 2001 From: Florian Dupret Date: Thu, 4 Jun 2020 08:34:46 +0200 Subject: [PATCH 2/2] Fix identation from 7105d34 --- public/v1/js/ff/accounts/reconcile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/v1/js/ff/accounts/reconcile.js b/public/v1/js/ff/accounts/reconcile.js index 354aacefae..182dc200ea 100644 --- a/public/v1/js/ff/accounts/reconcile.js +++ b/public/v1/js/ff/accounts/reconcile.js @@ -92,7 +92,7 @@ function selectAllReconcile(e) { // do nothing if line is already in target state if (check.prop('checked') === doCheck ) - return; + return; check.prop('checked', doCheck); // if checked, add to selected amount