kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-24 22:48:18 +00:00
Code Issues Projects Releases Wiki Activity

Clean up logs.

Browse Source
This commit is contained in:
James Cole
2025-05-11 07:23:35 +02:00
parent e61dadcbc6
commit 9b6314066b
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Console/Commands/Correction/CorrectsUnevenAmount.php
View File

@@ -77,8 +77,6 @@ class CorrectsUnevenAmount extends Command
->whereNotNull('foreign_amount')->get(['transactions.transaction_journal_id']); ->whereNotNull('foreign_amount')->get(['transactions.transaction_journal_id']);
$count = 0; $count = 0;
Log::debug(sprintf('Found %d potential journal(s)', $transactions->count()));
/** @var Transaction $transaction */ /** @var Transaction $transaction */
foreach ($transactions as $transaction) { foreach ($transactions as $transaction) {
/** @var null|TransactionJournal $journal */ /** @var null|TransactionJournal $journal */
@@ -120,6 +118,10 @@ class CorrectsUnevenAmount extends Command
++$count; ++$count;
} }
} }
if (0 === $count) {
return;
}
$this->friendlyPositive(sprintf('Fixed %d transfer(s) with unbalanced amounts.', $count));
} }
private function fixUnevenAmounts(): void private function fixUnevenAmounts(): void
@@ -343,8 +345,6 @@ class CorrectsUnevenAmount extends Command
->whereIn('account_types.type', [AccountTypeEnum::ASSET->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::LOAN->value]) ->whereIn('account_types.type', [AccountTypeEnum::ASSET->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::LOAN->value])
->get(['transactions.transaction_journal_id']); ->get(['transactions.transaction_journal_id']);
Log::debug(sprintf('Found %d potential journal(s)', $transactions->count()));
/** @var Transaction $transaction */ /** @var Transaction $transaction */
foreach ($transactions as $transaction) { foreach ($transactions as $transaction) {
/** @var null|TransactionJournal $journal */ /** @var null|TransactionJournal $journal */
@@ -359,7 +359,6 @@ class CorrectsUnevenAmount extends Command
continue; continue;
} }
Log::debug(sprintf('Potential fix for #%d', $journal->id));
$source = $journal->transactions()->where('amount', '<', 0)->first(); $source = $journal->transactions()->where('amount', '<', 0)->first();
$destination = $journal->transactions()->where('amount', '>', 0)->first(); $destination = $journal->transactions()->where('amount', '>', 0)->first();
if (null === $source || null === $destination) { if (null === $source || null === $destination) {