Lots of todo's [skip ci]

This commit is contained in:
James Cole
2016-03-02 13:51:56 +01:00
parent 500243b0b3
commit 9b69a6addd
18 changed files with 25 additions and 25 deletions

View File

@@ -54,7 +54,7 @@ final class AmountExactly extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$amount = $journal->amount_positive;
$amount = $journal->amount_positive; // TODO TransactionJournal cannot deliver "amount_positive".
$compare = $this->triggerValue;
$result = bccomp($amount, $compare, 4);
if ($result === 0) {

View File

@@ -54,7 +54,7 @@ final class AmountLess extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$amount = $journal->amount_positive;
$amount = $journal->amount_positive; // TODO TransactionJournal cannot deliver "amount_positive".
$compare = $this->triggerValue;
$result = bccomp($amount, $compare, 4);
if ($result === -1) {

View File

@@ -54,7 +54,7 @@ final class AmountMore extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$amount = $journal->amount_positive;
$amount = $journal->amount_positive; // TODO TransactionJournal cannot deliver "amount_positive".
$compare = $this->triggerValue;
$result = bccomp($amount, $compare, 4);
if ($result === 1) {

View File

@@ -53,7 +53,7 @@ final class FromAccountContains extends AbstractTrigger implements TriggerInterf
*/
public function triggered(TransactionJournal $journal)
{
$fromAccountName = strtolower($journal->source_account->name);
$fromAccountName = strtolower($journal->source_account->name);// TODO TransactionJournal cannot deliver "source_account"
$search = strtolower($this->triggerValue);
$strpos = strpos($fromAccountName, $search);

View File

@@ -53,7 +53,7 @@ final class FromAccountEnds extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$name = strtolower($journal->source_account->name);
$name = strtolower($journal->source_account->name);// TODO TransactionJournal cannot deliver "source_account"
$nameLength = strlen($name);
$search = strtolower($this->triggerValue);
$searchLength = strlen($search);

View File

@@ -53,7 +53,7 @@ final class FromAccountStarts extends AbstractTrigger implements TriggerInterfac
*/
public function triggered(TransactionJournal $journal)
{
$fromAccountName = strtolower($journal->source_account->name);
$fromAccountName = strtolower($journal->source_account->name);// TODO TransactionJournal cannot deliver "source_account"
$search = strtolower($this->triggerValue);
$part = substr($fromAccountName, 0, strlen($search));

View File

@@ -53,7 +53,7 @@ final class ToAccountContains extends AbstractTrigger implements TriggerInterfac
*/
public function triggered(TransactionJournal $journal)
{
$toAccountName = strtolower($journal->destination_account->name);
$toAccountName = strtolower($journal->destination_account->name); // TODO TransactionJournal cannot deliver "destination_account"
$search = strtolower($this->triggerValue);
$strpos = strpos($toAccountName, $search);

View File

@@ -53,7 +53,7 @@ final class ToAccountEnds extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$toAccountName = strtolower($journal->destination_account->name);
$toAccountName = strtolower($journal->destination_account->name); // TODO TransactionJournal cannot deliver "destination_account"
$toAccountNameLength = strlen($toAccountName);
$search = strtolower($this->triggerValue);
$searchLength = strlen($search);

View File

@@ -53,7 +53,7 @@ final class ToAccountIs extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$toAccountName = strtolower($journal->destination_account->name);
$toAccountName = strtolower($journal->destination_account->name); // TODO TransactionJournal cannot deliver "destination_account"
$search = strtolower($this->triggerValue);
if ($toAccountName == $search) {

View File

@@ -53,7 +53,7 @@ final class ToAccountStarts extends AbstractTrigger implements TriggerInterface
*/
public function triggered(TransactionJournal $journal)
{
$toAccountName = strtolower($journal->destination_account->name);
$toAccountName = strtolower($journal->destination_account->name); // TODO TransactionJournal cannot deliver "destination_account"
$search = strtolower($this->triggerValue);
$part = substr($toAccountName, 0, strlen($search));