kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-18 15:39:50 +00:00
Code Issues Projects Releases Wiki Activity

Suppress PHPMD messages and make sure to use route() [skip ci]

Browse Source
This commit is contained in:
James Cole
2019-06-09 09:39:56 +02:00
parent 57cfd7e3bc
commit a1929b0521
16 changed files with 93 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/Api/V1/Controllers/TransactionLinkControllerTest.php
View File

@@ -39,6 +39,9 @@ use Tests\TestCase;
/**
*
* Class TransactionLinkControllerTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class TransactionLinkControllerTest extends TestCase
{
@@ -100,7 +103,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data);
$response = $this->post(route('api.v1.transaction_links.store'), $data);
$response->assertStatus(200);
$response->assertHeader('Content-Type', 'application/vnd.api+json');
}
@@ -152,7 +155,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data, ['Accept' => 'application/json']);
$response = $this->post(route('api.v1.transaction_links.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(422);
$response->assertSee('Already have a link between inward and outward.');
@@ -207,7 +210,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data, ['Accept' => 'application/json']);
$response = $this->post(route('api.v1.transaction_links.store'), $data, ['Accept' => 'application/json']);
$response->assertSee('Invalid inward ID.'); // the creation moment.
$response->assertStatus(422);
$response->assertHeader('Content-Type', 'application/json');
@@ -260,7 +263,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data, ['Accept' => 'application/json']);
$response = $this->post(route('api.v1.transaction_links.store'), $data, ['Accept' => 'application/json']);
$response->assertSee('Invalid outward ID.');
$response->assertStatus(422);
$response->assertHeader('Content-Type', 'application/json');
@@ -312,7 +315,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data, ['Accept' => 'application/json']);
$response = $this->post(route('api.v1.transaction_links.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(500);
$response->assertSee('Source or destination is NULL.'); // the creation moment.
$response->assertHeader('Content-Type', 'application/json');
@@ -362,7 +365,7 @@ class TransactionLinkControllerTest extends TestCase
];
// test API
$response = $this->post('/api/v1/transaction_links', $data, ['Accept' => 'application/json']);
$response = $this->post(route('api.v1.transaction_links.store'), $data, ['Accept' => 'application/json']);
$response->assertStatus(422);
$response->assertSee('Invalid inward ID.'); // error message
$response->assertHeader('Content-Type', 'application/json');