kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-25 13:10:35 +00:00
Code Issues Projects Releases Wiki Activity

Fix code

Browse Source
This commit is contained in:
James Cole
2023-12-21 05:07:26 +01:00
parent 1f7ceb6df6
commit a445bc53cd
61 changed files with 165 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Services/Internal/Destroy/AccountDestroyService.php
View File

@@ -158,7 +158,7 @@ class AccountDestroyService
private function destroyRecurrences(Account $account): void
{
$recurrences = RecurrenceTransaction::where(
static function (Builder $q) use ($account) {
static function (Builder $q) use ($account): void {
$q->where('source_id', $account->id);
$q->orWhere('destination_id', $account->id);
}

2
app/Services/Internal/Support/CreditRecalculateService.php
View File

@@ -213,7 +213,7 @@ class CreditRecalculateService
/**
* If account direction is "debit" ("I owe this amount") the opening balance must always be AWAY from the account:
*/
private function validateOpeningBalance(Account $account, TransactionJournal $openingBalance)
private function validateOpeningBalance(Account $account, TransactionJournal $openingBalance): void
{
/** @var Transaction $source */
$source = $openingBalance->transactions()->where('amount', '<', 0)->first();

2
app/Services/Internal/Update/GroupUpdateService.php
View File

@@ -232,7 +232,7 @@ class GroupUpdateService
);
}
$collection->each(
static function (TransactionJournal $journal) use ($transactionGroup) {
static function (TransactionJournal $journal) use ($transactionGroup): void {
$transactionGroup->transactionJournals()->save($journal);
}
);