From a4524b3c2cdf8369bbb38cf970d2c7500aebdcf9 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 6 May 2018 20:42:07 +0200 Subject: [PATCH] Throw exception with empty amount. --- app/Factory/TransactionFactory.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/Factory/TransactionFactory.php b/app/Factory/TransactionFactory.php index 468ff3f17e..ae8ee25b76 100644 --- a/app/Factory/TransactionFactory.php +++ b/app/Factory/TransactionFactory.php @@ -24,6 +24,7 @@ declare(strict_types=1); namespace FireflyIII\Factory; +use FireflyIII\Exceptions\FireflyException; use FireflyIII\Models\Transaction; use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; @@ -45,10 +46,14 @@ class TransactionFactory * @param array $data * * @return Transaction + * @throws FireflyException */ - public function create(array $data): Transaction + public function create(array $data): ?Transaction { $currencyId = isset($data['currency']) ? $data['currency']->id : $data['currency_id']; + if ('' === $data['amount']) { + throw new FireflyException('Amount is an empty string, which Firefly III cannot handle. Apologies.'); + } return Transaction::create( [ @@ -72,6 +77,7 @@ class TransactionFactory * @param array $data * * @return Collection + * @throws FireflyException */ public function createPair(TransactionJournal $journal, array $data): Collection {