kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Make method smaller.

Browse Source
This commit is contained in:
James Cole
2020-03-16 19:40:48 +01:00
parent 4334928fbd
commit a7fffa5868
2 changed files with 24 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/Http/Controllers/Transaction/ShowController.php
View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Transaction;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Http\Controllers\Controller;
use FireflyIII\Models\TransactionGroup;
@@ -84,11 +83,11 @@ class ShowController extends Controller
$first = $transactionGroup->transactionJournals()->first(['transaction_journals.*']);
$splits = $transactionGroup->transactionJournals()->count();
if(null === $first) {
if (null === $first) {
throw new FireflyException('This transaction is broken :(.');
}
$type = (string)trans(sprintf('firefly.%s',$first->transactionType->type));
$type = (string) trans(sprintf('firefly.%s', $first->transactionType->type));
$title = 1 === $splits ? $first->description : $transactionGroup->title;
$subTitle = sprintf('%s: "%s"', $type, $title);
@@ -113,10 +112,19 @@ class ShowController extends Controller
$links = $this->repository->getLinks($transactionGroup);
return view(
'transactions.show', compact(
'transactionGroup', 'amounts', 'first', 'type', 'subTitle', 'splits', 'groupArray',
'events', 'attachments', 'links'
)
'transactions.show',
compact(
'transactionGroup',
'amounts',
'first',
'type',
'subTitle',
'splits',
'groupArray',
'events',
'attachments',
'links'
)
);
}