kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-06-13 06:39:05 +02:00
parent 6fdfa722dd
commit aacd218056
13 changed files with 1204 additions and 591 deletions
Download Patch File Download Diff File Expand all files Collapse all files

600
tests/Unit/Console/Commands/Upgrade/JournalCurrenciesTest.php
View File

@@ -49,306 +49,306 @@ class JournalCurrenciesTest extends TestCase
parent::setUp();
Log::info(sprintf('Now in %s.', get_class($this)));
}
/**
* Basic run. Would not change anything.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandle(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
// update transfer if necessary for the test:
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn(new Collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput('All transactions are correct.')
->assertExitCode(0);
// nothing changed, so no verification.
}
/**
* Submit a single transfer which has no issues.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandleTransfer(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
$transfer = $this->getRandomTransfer();
// update transfer if necessary for the test:
$collection = new Collection([$transfer]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$accountRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
// return single tranfer
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn($collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput('Verified 1 transaction(s) and journal(s).')
->assertExitCode(0);
// nothing changed, so no verification.
}
/**
* Submit a single transfer where the source account has no currency preference.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandleTransferSourceNoPref(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
$transfer = $this->getRandomTransfer();
// edit source to remove currency preference:
/** @var Account $source */
$source = $transfer->transactions()->where('amount', '<', 0)->first()->account;
// AccountMeta::where('account_id', $source->id)->where('name', 'currency_id')->delete();
// update transfer if necessary for the test:
$collection = new Collection([$transfer]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$accountRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
// return single transfer
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn($collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
// return NULL for first currency ID and currency.
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturnNull();
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturnNull();
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $source->id, $source->name))
->assertExitCode(0);
// nothing changed, so no verification.
}
/**
* Submit a single transfer where the source transaction has no currency set.
* Because this is not done over repositories, we must edit the DB.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandleTransferSourceNoCurrency(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
$transfer = $this->getRandomTransfer();
/** @var Transaction $source */
$source = $transfer->transactions()->where('amount', '<', 0)->first();
$source->transaction_currency_id = null;
$source->save();
// update transfer if necessary for the test:
$collection = new Collection([$transfer]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$accountRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
// return single tranfer
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn($collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput(sprintf('Transaction #%d has no currency setting, now set to %s.', $source->id, $euro->code))
->expectsOutput('Verified 2 transaction(s) and journal(s).')
->assertExitCode(0);
// check transaction
$this->assertCount(1, Transaction::where('id', $source->id)->where('transaction_currency_id', $euro->id)->get());
}
/**
* Submit a single transfer where the source transaction has a different currency than the source account does.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandleMismatchedTransfer(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
$usd = TransactionCurrency::where('code', 'USD')->first();
$transfer = $this->getRandomTransfer();
/** @var Transaction $source */
$source = $transfer->transactions()->where('amount', '<', 0)->first();
$source->transaction_currency_id = $usd->id;
$source->save();
// update transfer if necessary for the test:
$collection = new Collection([$transfer]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$accountRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
// return single tranfer
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn($collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput(
sprintf(
'Transaction #%d has a currency setting #%d that should be #%d. Amount remains %s, currency is changed.',
$source->id,
$source->transaction_currency_id,
$euro->id,
$source->amount
)
)
->expectsOutput('Verified 2 transaction(s) and journal(s).')
->assertExitCode(0);
// nothing changed, so no verification.
}
/**
* Submit a single transfer where the destination account has no currency preference.
*
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
*/
public function testHandleTransferNoDestinationCurrency(): void
{
// mock classes
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$euro = TransactionCurrency::find(1);
$transfer = $this->getRandomTransfer();
/** @var Account $destination */
$destination = $transfer->transactions()->where('amount', '>', 0)->first()->account;
// update transfer if necessary for the test:
$collection = new Collection([$transfer]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
// mock stuff
$accountRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
// return single tranfer
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::TRANSFER]])
->andReturn($collection);
// for the "other journals" check, return nothing.
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
->andReturn(new Collection);
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id, 0);
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro, null);
// transaction would be verified, nothing more.
$this->artisan('firefly-iii:journal-currencies')
->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $destination->id, $destination->name))
->assertExitCode(0);
// nothing changed, so no verification.
}
//
// /**
// * Basic run. Would not change anything.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandle(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
//
// // update transfer if necessary for the test:
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn(new Collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput('All transactions are correct.')
// ->assertExitCode(0);
// // nothing changed, so no verification.
//
// }
//
// /**
// * Submit a single transfer which has no issues.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandleTransfer(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
// $transfer = $this->getRandomTransfer();
//
// // update transfer if necessary for the test:
// $collection = new Collection([$transfer]);
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $accountRepos->shouldReceive('setUser')->atLeast()->once();
// $journalRepos->shouldReceive('setUser')->atLeast()->once();
// $currencyRepos->shouldReceive('setUser')->atLeast()->once();
//
// // return single tranfer
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn($collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// $accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
// $currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput('Verified 1 transaction(s) and journal(s).')
// ->assertExitCode(0);
// // nothing changed, so no verification.
// }
//
// /**
// * Submit a single transfer where the source account has no currency preference.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandleTransferSourceNoPref(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
// $transfer = $this->getRandomTransfer();
//
// // edit source to remove currency preference:
// /** @var Account $source */
// $source = $transfer->transactions()->where('amount', '<', 0)->first()->account;
//// AccountMeta::where('account_id', $source->id)->where('name', 'currency_id')->delete();
//
// // update transfer if necessary for the test:
// $collection = new Collection([$transfer]);
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $accountRepos->shouldReceive('setUser')->atLeast()->once();
// $journalRepos->shouldReceive('setUser')->atLeast()->once();
// $currencyRepos->shouldReceive('setUser')->atLeast()->once();
//
// // return single transfer
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn($collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// // return NULL for first currency ID and currency.
// $accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturnNull();
// $currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturnNull();
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $source->id, $source->name))
// ->assertExitCode(0);
// // nothing changed, so no verification.
//
// }
//
// /**
// * Submit a single transfer where the source transaction has no currency set.
// * Because this is not done over repositories, we must edit the DB.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandleTransferSourceNoCurrency(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
// $transfer = $this->getRandomTransfer();
// /** @var Transaction $source */
// $source = $transfer->transactions()->where('amount', '<', 0)->first();
// $source->transaction_currency_id = null;
// $source->save();
//
// // update transfer if necessary for the test:
// $collection = new Collection([$transfer]);
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $accountRepos->shouldReceive('setUser')->atLeast()->once();
// $journalRepos->shouldReceive('setUser')->atLeast()->once();
// $currencyRepos->shouldReceive('setUser')->atLeast()->once();
//
// // return single tranfer
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn($collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// $accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
// $currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput(sprintf('Transaction #%d has no currency setting, now set to %s.', $source->id, $euro->code))
// ->expectsOutput('Verified 2 transaction(s) and journal(s).')
// ->assertExitCode(0);
//
// // check transaction
// $this->assertCount(1, Transaction::where('id', $source->id)->where('transaction_currency_id', $euro->id)->get());
// }
//
// /**
// * Submit a single transfer where the source transaction has a different currency than the source account does.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandleMismatchedTransfer(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
// $usd = TransactionCurrency::where('code', 'USD')->first();
// $transfer = $this->getRandomTransfer();
//
// /** @var Transaction $source */
// $source = $transfer->transactions()->where('amount', '<', 0)->first();
// $source->transaction_currency_id = $usd->id;
// $source->save();
//
// // update transfer if necessary for the test:
// $collection = new Collection([$transfer]);
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $accountRepos->shouldReceive('setUser')->atLeast()->once();
// $journalRepos->shouldReceive('setUser')->atLeast()->once();
// $currencyRepos->shouldReceive('setUser')->atLeast()->once();
//
// // return single tranfer
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn($collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// $accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
// $currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput(
// sprintf(
// 'Transaction #%d has a currency setting #%d that should be #%d. Amount remains %s, currency is changed.',
// $source->id,
// $source->transaction_currency_id,
// $euro->id,
// $source->amount
// )
// )
// ->expectsOutput('Verified 2 transaction(s) and journal(s).')
// ->assertExitCode(0);
// // nothing changed, so no verification.
// }
//
// /**
// * Submit a single transfer where the destination account has no currency preference.
// *
// * @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
// */
// public function testHandleTransferNoDestinationCurrency(): void
// {
// // mock classes
// $accountRepos = $this->mock(AccountRepositoryInterface::class);
// $currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
// $journalRepos = $this->mock(JournalRepositoryInterface::class);
// $euro = TransactionCurrency::find(1);
// $transfer = $this->getRandomTransfer();
//
// /** @var Account $destination */
// $destination = $transfer->transactions()->where('amount', '>', 0)->first()->account;
//
// // update transfer if necessary for the test:
// $collection = new Collection([$transfer]);
// $false = new Configuration;
// $false->data = false;
// FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
// FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
//
// // mock stuff
// $accountRepos->shouldReceive('setUser')->atLeast()->once();
// $journalRepos->shouldReceive('setUser')->atLeast()->once();
// $currencyRepos->shouldReceive('setUser')->atLeast()->once();
//
// // return single tranfer
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::TRANSFER]])
// ->andReturn($collection);
//
// // for the "other journals" check, return nothing.
// $journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
// ->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
// ->andReturn(new Collection);
//
// $accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id, 0);
// $currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro, null);
//
// // transaction would be verified, nothing more.
// $this->artisan('firefly-iii:journal-currencies')
// ->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $destination->id, $destination->name))
// ->assertExitCode(0);
// // nothing changed, so no verification.
// }
}

96
tests/Unit/Console/Commands/Upgrade/MigrateAttachmentsTest.php Normal file
View File

@@ -0,0 +1,96 @@
<?php
/**
* MigrateAttachmentsTest.php
* Copyright (c) 2019 thegrumpydictator@gmail.com
*
* This file is part of Firefly III.
*
* Firefly III is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Firefly III is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
namespace Tests\Unit\Console\Commands\Upgrade;
use FireflyConfig;
use FireflyIII\Models\Attachment;
use FireflyIII\Models\Configuration;
use FireflyIII\Models\Note;
use FireflyIII\Models\TransactionJournal;
use Log;
use Tests\TestCase;
/**
* Class MigrateAttachmentsTest
*/
class MigrateAttachmentsTest extends TestCase
{
/**
*
*/
public function setUp(): void
{
parent::setUp();
Log::info(sprintf('Now in %s.', get_class($this)));
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateAttachments
*/
public function testHandle(): void
{
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_attachments', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_attachments', true]);
// assume all is well.
$this->artisan('firefly-iii:migrate-attachments')
->expectsOutput('All attachments are OK.')
->assertExitCode(0);
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateAttachments
*/
public function testHandleMigrate(): void
{
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_attachments', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_attachments', true]);
$attachment = Attachment::create(
[
'user_id' => 1,
'attachable_id' => 1,
'attachable_type' => TransactionJournal::class,
'description' => 'Hello',
'md5' => md5('hello'),
'filename' => 'test.pdf',
'mime' => 'text/plain',
'size' => 1,
]);
// assume all is well.
$this->artisan('firefly-iii:migrate-attachments')
->expectsOutput('Updated 1 attachment(s).')
->assertExitCode(0);
$this->assertCount(0, Attachment::where('id', $attachment->id)->where('description', '!=', '')->get());
$this->assertCount(1, Attachment::where('id', $attachment->id)->where('description', '=', '')->get());
$this->assertCount(1, Note::where('noteable_id', $attachment->id)->where('noteable_type', Attachment::class)->get());
$attachment->forceDelete();
}
}

94
tests/Unit/Console/Commands/Upgrade/MigrateJournalNotesTest.php Normal file
View File

@@ -0,0 +1,94 @@
<?php
/**
* MigrateJournalNotesTest.php
* Copyright (c) 2019 thegrumpydictator@gmail.com
*
* This file is part of Firefly III.
*
* Firefly III is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Firefly III is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
namespace Tests\Unit\Console\Commands\Upgrade;
use FireflyConfig;
use FireflyIII\Models\Configuration;
use FireflyIII\Models\TransactionJournalMeta;
use Log;
use Tests\TestCase;
/**
* Class MigrateJournalNotesTest
*/
class MigrateJournalNotesTest extends TestCase
{
/**
*
*/
public function setUp(): void
{
parent::setUp();
Log::info(sprintf('Now in %s.', get_class($this)));
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateJournalNotes
*/
public function testHandle(): void
{
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_notes', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_notes', true]);
// assume all is well.
$this->artisan('firefly-iii:migrate-notes')
->expectsOutput('No notes to migrate.')
->assertExitCode(0);
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateJournalNotes
*/
public function testHandleNote(): void
{
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrate_notes', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrate_notes', true]);
$journal = $this->getRandomWithdrawal();
$meta = TransactionJournalMeta::create(
[
'transaction_journal_id' => $journal->id,
'name' => 'notes',
'data' => json_encode('Some note.'),
'hash' => 'Some hash',
]
);
// assume one is fixed.
$this->artisan('firefly-iii:migrate-notes')
->expectsOutput('Migrated 1 note(s).')
->assertExitCode(0);
$this->assertCount(0, TransactionJournalMeta
::where('name', 'notes')
->where('id', $meta->id)
->whereNull('deleted_at')
->get());
}
}

280
tests/Unit/Console/Commands/Upgrade/MigrateToGroupsTest.php
View File

@@ -23,12 +23,13 @@ declare(strict_types=1);
namespace Tests\Unit\Console\Commands\Upgrade;
use Carbon\Carbon;
use FireflyConfig;
use FireflyIII\Factory\TransactionJournalFactory;
use FireflyIII\Factory\TransactionGroupFactory;
use FireflyIII\Models\Configuration;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Services\Internal\Destroy\JournalDestroyService;
use Illuminate\Support\Collection;
use Log;
use Mockery;
@@ -49,140 +50,199 @@ class MigrateToGroupsTest extends TestCase
}
/**
* Basic test. Assume nothing is wrong.
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToGroups
*/
public function testAlreadyExecuted(): void
public function testHandle(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
$journalRepos = $this->mock(JournalRepositoryInterface::class);
return;
$this->mock(TransactionJournalFactory::class);
$this->mock(JournalRepositoryInterface::class);
// mock calls:
$journalRepos->shouldReceive('getSplitJournals')
->atLeast()->once()
->andReturn(new Collection);
$journalRepos->shouldReceive('getJournalsWithoutGroup')
->atLeast()->once()
->andReturn([]);
$configObject = new Configuration;
$configObject->data = true;
FireflyConfig::shouldReceive('get')->withArgs(['migrated_to_groups_4780', false])->andReturn($configObject)->once();
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrated_to_groups', true]);
// assume all is well.
$this->artisan('firefly-iii:migrate-to-groups')
->expectsOutput('Database already seems to be migrated.')
->expectsOutput('No journals to migrate to groups.')
->assertExitCode(0);
}
/**
* Return a journal without a group.
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToGroups
*/
public function testBasic(): void
public function testHandleNoGroup(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$asset = $this->getRandomAsset();
$expense = $this->getRandomExpense();
$journal = TransactionJournal::create(
[
'user_id' => 1,
'transaction_currency_id' => 1,
'transaction_type_id' => 1,
'description' => 'Test',
'tag_count' => 0,
'date' => '2019-01-01',
]
);
$one = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $asset->id,
'amount' => '-10',
'identifier' => 1,
]
);
$two = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $expense->id,
'amount' => '10',
'identifier' => 1,
]
);
$array = $journal->toArray();
return;
$journalFactory = $this->mock(TransactionJournalFactory::class);
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$withdrawal = $this->getRandomSplitWithdrawal();
$collection = new Collection([$withdrawal]);
$date = new Carbon;
$opposing = new Transaction;
$opposing->account_id = 13;
// mock calls:
$journalRepos->shouldReceive('getSplitJournals')
->atLeast()->once()
->andReturn(new Collection);
$journalRepos->shouldReceive('getJournalsWithoutGroup')
->atLeast()->once()
->andReturn([$array]);
// not yet executed:
$configObject = new Configuration;
$configObject->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['migrated_to_groups_4780', false])->andReturn($configObject)->once();
FireflyConfig::shouldReceive('set')->withArgs(['migrated_to_groups_4780', true])->once();
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrated_to_groups', true]);
// assume all is well.
$this->artisan('firefly-iii:migrate-to-groups')
->expectsOutput('Migrated 1 transaction journal(s).')
->assertExitCode(0);
// no longer without a group.
$this->assertCount(0, TransactionJournal::where('id', $journal->id)->whereNull('transaction_group_id')->get());
$journal->transactionGroup()->forceDelete();
$one->forceDelete();
$two->forceDelete();
$journal->forceDelete();
}
/**
* Create split withdrawal and see what the system will do.
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToGroups
*/
public function testHandleSplitJournal(): void
{
$asset = $this->getRandomAsset();
$expense = $this->getRandomExpense();
$group = $this->getRandomWithdrawalGroup();
$journal = TransactionJournal::create(
[
'user_id' => 1,
'transaction_currency_id' => 1,
'transaction_type_id' => 1,
'description' => 'Test',
'tag_count' => 0,
'date' => '2019-01-01',
]
);
$one = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $asset->id,
'amount' => '-10',
'identifier' => 1,
]
);
$two = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $expense->id,
'amount' => '10',
'identifier' => 1,
]
);
$three = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $asset->id,
'amount' => '-12',
'identifier' => 2,
]
);
$four = Transaction::create(
[
'transaction_journal_id' => $journal->id,
'account_id' => $expense->id,
'amount' => '12',
'identifier' => 2,
]
);
// calls to repository:
$journalRepos = $this->mock(JournalRepositoryInterface::class);
$service = $this->mock(JournalDestroyService::class);
$factory = $this->mock(TransactionGroupFactory::class);
// mock calls:
$journalRepos->shouldReceive('setUser')->atLeast()->once();
$journalRepos->shouldReceive('getJournalBudgetId')->atLeast()->once()->andReturn(1);
$journalRepos->shouldReceive('getJournalCategoryId')->atLeast()->once()->andReturn(2);
$journalRepos->shouldReceive('findOpposingTransaction')->atLeast()->once()->andReturn($opposing);
$journalRepos->shouldReceive('getNoteText')->atLeast()->once()->andReturn('I am some notes.');
$journalRepos->shouldReceive('getTags')->atLeast()->once()->andReturn(['a', 'b']);
$journalRepos->shouldReceive('getSplitJournals')->once()->andReturn($collection);
// all meta field calls.
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'internal-reference'])->andReturn('ABC');
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-cc'])->andReturnNull();
// mock journal things:
$journalRepos->shouldReceive('getJournalBudgetId')->atLeast()->once()->andReturn(0);
$journalRepos->shouldReceive('getJournalCategoryId')->atLeast()->once()->andReturn(0);
$journalRepos->shouldReceive('getNoteText')->atLeast()->once()->andReturn('Some note.');
$journalRepos->shouldReceive('getTags')->atLeast()->once()->andReturn(['A', 'B']);
$journalRepos->shouldReceive('getMetaField')->atLeast()
->withArgs([Mockery::any(), Mockery::any()])
->once()->andReturn(null);
$journalRepos->shouldReceive('getMetaDate')->atLeast()
->withArgs([Mockery::any(), Mockery::any()])
->once()->andReturn(null);
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-ct-op'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-ct-id'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-db'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-country'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-ep'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-ci'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'sepa-batch-id'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'external-id'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'original-source'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'recurrence_id'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_payment_id'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'importHash'])->andReturnNull();
$journalRepos->shouldReceive('getMetaField')->atLeast()->once()->withArgs([Mockery::any(), 'importHashV2'])->andReturnNull();
// create a group
$factory->shouldReceive('create')->atLeast()->once()->andReturn($group);
$service->shouldReceive('destroy')->atLeast()->once();
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'interest_date'])->andReturn($date);
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'book_date'])->andReturnNull();
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'process_date'])->andReturnNull();
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'due_date'])->andReturnNull();
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'payment_date'])->andReturnNull();
$journalRepos->shouldReceive('getMetaDate')->atLeast()->once()->withArgs([Mockery::any(), 'invoice_date'])->andReturnNull();
$factory->shouldReceive('setUser')->atLeast()->once();
// calls to factory
$journalFactory->shouldReceive('setUser')->atLeast()->once();
$journalFactory->shouldReceive('create')->atLeast()->once()->withAnyArgs()->andReturn(new Collection());
$journalRepos->shouldReceive('getSplitJournals')
->atLeast()->once()
->andReturn(new Collection([$journal]));
$journalRepos->shouldReceive('getJournalsWithoutGroup')
->atLeast()->once()
->andReturn([]);
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_migrated_to_groups', true]);
$this->artisan('firefly-iii:migrate-to-groups')
->expectsOutput('Going to un-split 1 transaction(s). This could take some time.')
->expectsOutput('Migrated 1 transaction journal(s).')
->assertExitCode(0);
// delete the created stuff:
$one->forceDelete();
$two->forceDelete();
$three->forceDelete();
$four->forceDelete();
$journal->forceDelete();
// the calls above let me know it's OK.
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToGroups
*/
public function testForced(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
$this->mock(TransactionJournalFactory::class);
$repository = $this->mock(JournalRepositoryInterface::class);
$repository->shouldReceive('getSplitJournals')->andReturn(new Collection);
$configObject = new Configuration;
$configObject->data = true;
FireflyConfig::shouldReceive('get')->withArgs(['migrated_to_groups_4780', false])->andReturn($configObject)->once();
FireflyConfig::shouldReceive('set')->withArgs(['migrated_to_groups_4780', true])->once();
$this->artisan('firefly-iii:migrate-to-groups --force')
->expectsOutput('Forcing the migration.')
->expectsOutput('Found no split journals. Nothing to do.')
->assertExitCode(0);
}
/**
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToGroups
*/
public function testNotSplit(): void
{
$this->markTestIncomplete('Needs to be rewritten for v4.8.0');
return;
$this->mock(TransactionJournalFactory::class);
$repository = $this->mock(JournalRepositoryInterface::class);
$withdrawal = $this->getRandomWithdrawal();
$repository->shouldReceive('getSplitJournals')->andReturn(new Collection([$withdrawal]));
$configObject = new Configuration;
$configObject->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['migrated_to_groups_4780', false])->andReturn($configObject)->once();
FireflyConfig::shouldReceive('set')->withArgs(['migrated_to_groups_4780', true])->once();
$this->artisan('firefly-iii:migrate-to-groups')
->expectsOutput('Going to un-split 1 transaction(s). This could take some time.')
->assertExitCode(0);
}
}

316
tests/Unit/Console/Commands/Upgrade/MigrateToRulesTest.php Normal file
View File

@@ -0,0 +1,316 @@
<?php
/**
* MigrateToRulesTest.php
* Copyright (c) 2019 thegrumpydictator@gmail.com
*
* This file is part of Firefly III.
*
* Firefly III is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Firefly III is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
namespace Tests\Unit\Console\Commands\Upgrade;
use FireflyConfig;
use FireflyIII\Models\Bill;
use FireflyIII\Models\Configuration;
use FireflyIII\Models\Preference;
use FireflyIII\Repositories\Bill\BillRepositoryInterface;
use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use Illuminate\Support\Collection;
use Log;
use Mockery;
use Preferences;
use Tests\TestCase;
/**
* Class MigrateToRulesTest
*/
class MigrateToRulesTest extends TestCase
{
/**
*
*/
public function setUp(): void
{
parent::setUp();
Log::info(sprintf('Now in %s.', get_class($this)));
}
/**
* Basic test. Assume nothing is wrong.
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToRules
*/
public function testHandle(): void
{
// mock repositories:
$userRepository = $this->mock(UserRepositoryInterface::class);
$ruleGroupRepository = $this->mock(RuleGroupRepositoryInterface::class);
$billRepository = $this->mock(BillRepositoryInterface::class);
$ruleRepository = $this->mock(RuleRepositoryInterface::class);
$group = $this->user()->ruleGroups()->inRandomOrder()->first();
$bill = $this->user()->bills()->inRandomOrder()->first();
// mock all calls.
$userRepository->shouldReceive('all')->atLeast()->once()
->andReturn(new Collection([$this->user()]));
$ruleRepository->shouldReceive('setUser')->atLeast()->once();
$ruleGroupRepository->shouldReceive('setUser')->atLeast()->once();
$ruleGroupRepository->shouldReceive('findByTitle')
->withArgs(['Rule group for bills'])->atLeast()->once()->andReturnNull();
// rule group repos should try to store a rule group in response to the result above.
$ruleGroupRepository->shouldReceive('store')->atLeast()->once()->andReturn($group);
// bill repos should return one rule.
$billRepository->shouldReceive('setUser')->atLeast()->once();
$billRepository->shouldReceive('getBills')->atLeast()->once()
->andReturn(new Collection([$bill]));
// configuration
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_bills_to_rules', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_bills_to_rules', true]);
// preferences
$language = new Preference;
$language->data = 'en_US';
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'language', 'en_US'])->andReturn($language);
// assume all is well.
$this->artisan('firefly-iii:bills-to-rules')
->expectsOutput('All bills are OK.')
->assertExitCode(0);
}
/**
* Basic test. Give command an unmigrated bill. This bill has the same amount_min
* as amount_max
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToRules
*/
public function testHandleEvenBill(): void
{
$bill = Bill::create(
[
'user_id' => $this->user()->id,
'transaction_currency_id' => null,
'name' => 'I am a bill',
'match' => 'some,kind,of,match',
'amount_min' => '30',
'amount_max' => '30',
'date' => '2019-01-01',
'repeat_freq' => 'monthly',
]
);
// mock repositories:
$userRepository = $this->mock(UserRepositoryInterface::class);
$ruleGroupRepository = $this->mock(RuleGroupRepositoryInterface::class);
$billRepository = $this->mock(BillRepositoryInterface::class);
$ruleRepository = $this->mock(RuleRepositoryInterface::class);
$group = $this->user()->ruleGroups()->inRandomOrder()->first();
// mock all calls.
$userRepository->shouldReceive('all')->atLeast()->once()
->andReturn(new Collection([$this->user()]));
$ruleRepository->shouldReceive('setUser')->atLeast()->once();
// this is what rule repos should receive:
$argumentRule = [
'rule_group_id' => $group->id,
'active' => true,
'strict' => false,
'stop_processing' => false, // field is no longer used.
'title' => 'Auto-generated rule for bill "I am a bill"',
'description' => 'This rule is auto-generated to try to match bill "I am a bill".',
'trigger' => 'store-journal',
'triggers' => [
[
'type' => 'description_contains',
'value' => 'some kind of match',
],
[
'type' => 'amount_exactly',
'value' => $bill->amount_min,
],
],
'actions' => [
'type' => 'link_to_bill',
'value' => $bill->name,
],
];
// this is what the bill repos should receive:
$argumentBill = [
'currency_id' => $bill->transaction_currency_id,
'name' => $bill->name,
'match' => 'MIGRATED_TO_RULES',
'amount_min' => $bill->amount_min,
'amount_max' => $bill->amount_max,
'date' => $bill->date,
'repeat_freq' => $bill->repeat_freq,
'skip' => $bill->skip,
'active' => $bill->active,
];
$ruleRepository->shouldReceive('store')->atLeast()->once()->withArgs([$argumentRule]);
// rule group repos should try to store a rule group in response to the result above.
$ruleGroupRepository->shouldReceive('setUser')->atLeast()->once();
$ruleGroupRepository->shouldReceive('findByTitle')
->withArgs(['Rule group for bills'])->atLeast()->once()->andReturnNull();
$ruleGroupRepository->shouldReceive('store')->atLeast()->once()->andReturn($group);
// bill repos should return one rule.
$billRepository->shouldReceive('setUser')->atLeast()->once();
$billRepository->shouldReceive('getBills')->atLeast()->once()
->andReturn(new Collection([$bill]));
$billRepository->shouldReceive('update')->atLeast()->once()
->withArgs([Mockery::any(), $argumentBill]);
// configuration
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_bills_to_rules', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_bills_to_rules', true]);
// preferences
$language = new Preference;
$language->data = 'en_US';
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'language', 'en_US'])->andReturn($language);
// assume all is well.
$this->artisan('firefly-iii:bills-to-rules')
->expectsOutput('Verified and fixed 1 bill(s).')
->assertExitCode(0);
}
/**
* Basic test. Give command an unmigrated bill. This bill has a different amount_min
* from the amount_max
*
* @covers \FireflyIII\Console\Commands\Upgrade\MigrateToRules
*/
public function testHandleUnevenBill(): void
{
$bill = Bill::create(
[
'user_id' => $this->user()->id,
'transaction_currency_id' => null,
'name' => 'I am a bill',
'match' => 'some,kind,of,match',
'amount_min' => '30',
'amount_max' => '40',
'date' => '2019-01-01',
'repeat_freq' => 'monthly',
]
);
// mock repositories:
$userRepository = $this->mock(UserRepositoryInterface::class);
$ruleGroupRepository = $this->mock(RuleGroupRepositoryInterface::class);
$billRepository = $this->mock(BillRepositoryInterface::class);
$ruleRepository = $this->mock(RuleRepositoryInterface::class);
$group = $this->user()->ruleGroups()->inRandomOrder()->first();
// mock all calls.
$userRepository->shouldReceive('all')->atLeast()->once()
->andReturn(new Collection([$this->user()]));
$ruleRepository->shouldReceive('setUser')->atLeast()->once();
// this is what rule repos should receive:
$argumentRule = [
'rule_group_id' => $group->id,
'active' => true,
'strict' => false,
'stop_processing' => false, // field is no longer used.
'title' => 'Auto-generated rule for bill "I am a bill"',
'description' => 'This rule is auto-generated to try to match bill "I am a bill".',
'trigger' => 'store-journal',
'triggers' => [
[
'type' => 'description_contains',
'value' => 'some kind of match',
],
[
'type' => 'amount_less',
'value' => $bill->amount_max,
],
[
'type' => 'amount_more',
'value' => $bill->amount_min,
],
],
'actions' => [
'type' => 'link_to_bill',
'value' => $bill->name,
],
];
// this is what the bill repos should receive:
$argumentBill = [
'currency_id' => $bill->transaction_currency_id,
'name' => $bill->name,
'match' => 'MIGRATED_TO_RULES',
'amount_min' => $bill->amount_min,
'amount_max' => $bill->amount_max,
'date' => $bill->date,
'repeat_freq' => $bill->repeat_freq,
'skip' => $bill->skip,
'active' => $bill->active,
];
$ruleRepository->shouldReceive('store')->atLeast()->once()->withArgs([$argumentRule]);
// rule group repos should try to store a rule group in response to the result above.
$ruleGroupRepository->shouldReceive('setUser')->atLeast()->once();
$ruleGroupRepository->shouldReceive('findByTitle')
->withArgs(['Rule group for bills'])->atLeast()->once()->andReturnNull();
$ruleGroupRepository->shouldReceive('store')->atLeast()->once()->andReturn($group);
// bill repos should return one rule.
$billRepository->shouldReceive('setUser')->atLeast()->once();
$billRepository->shouldReceive('getBills')->atLeast()->once()
->andReturn(new Collection([$bill]));
$billRepository->shouldReceive('update')->atLeast()->once()
->withArgs([Mockery::any(), $argumentBill]);
// configuration
$false = new Configuration;
$false->data = false;
FireflyConfig::shouldReceive('get')->withArgs(['4780_bills_to_rules', false])->andReturn($false);
FireflyConfig::shouldReceive('set')->withArgs(['4780_bills_to_rules', true]);
// preferences
$language = new Preference;
$language->data = 'en_US';
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'language', 'en_US'])->andReturn($language);
// assume all is well.
$this->artisan('firefly-iii:bills-to-rules')
->expectsOutput('Verified and fixed 1 bill(s).')
->assertExitCode(0);
}
}