From ae2b28fdee6685c1f4a8c37dd3ae9130d59076c0 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 31 Mar 2020 07:41:48 +0200 Subject: [PATCH] Use correct methods. --- app/Services/Internal/Support/RecurringTransactionTrait.php | 2 ++ app/Services/Internal/Update/JournalUpdateService.php | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/app/Services/Internal/Support/RecurringTransactionTrait.php b/app/Services/Internal/Support/RecurringTransactionTrait.php index f1f15f8522..bf6f2f9ba6 100644 --- a/app/Services/Internal/Support/RecurringTransactionTrait.php +++ b/app/Services/Internal/Support/RecurringTransactionTrait.php @@ -106,6 +106,8 @@ trait RecurringTransactionTrait throw new FireflyException(sprintf('Destination invalid: %s', $validator->destError)); // @codeCoverageIgnore } + // TODO typeOverrule: the account validator may have another opinion on the transaction type. + $transaction = new RecurrenceTransaction( [ 'recurrence_id' => $recurrence->id, diff --git a/app/Services/Internal/Update/JournalUpdateService.php b/app/Services/Internal/Update/JournalUpdateService.php index d2343c50c1..a8746201c8 100644 --- a/app/Services/Internal/Update/JournalUpdateService.php +++ b/app/Services/Internal/Update/JournalUpdateService.php @@ -362,6 +362,8 @@ class JournalUpdateService $result = $validator->validateDestination($destId, $destName, null); Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true))); + // TODO typeOverrule: the account validator may have another opinion on the transaction type. + // validate submitted info: return $result; } @@ -394,6 +396,8 @@ class JournalUpdateService $result = $validator->validateSource($sourceId, $sourceName, null); Log::debug(sprintf('hasValidSourceAccount(%d, "%s") will return %s', $sourceId, $sourceName, var_export($result, true))); + // TODO typeOverrule: the account validator may have another opinion on the transaction type. + // validate submitted info: return $result; }