kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 23:45:10 +00:00
Code Issues Projects Releases Wiki Activity

fix phpstan issues.

Browse Source
This commit is contained in:
James Cole
2023-11-28 17:18:31 +01:00
parent 7cb919e9c2
commit b0a39c00ba
25 changed files with 184 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/TransactionRules/Actions/AddTag.php
View File

@@ -56,7 +56,9 @@ class AddTag implements ActionInterface
// journal has this tag maybe?
/** @var TagFactory $factory */
$factory = app(TagFactory::class);
$factory->setUser(User::find($journal['user_id']));
/** @var User $user */
$user = User::find($journal['user_id']);
$factory->setUser($user);
$tag = $factory->findOrCreate($this->action->action_value);
if (null === $tag) {
@@ -74,6 +76,7 @@ class AddTag implements ActionInterface
// add to journal:
DB::table('tag_transaction_journal')->insert(['tag_id' => $tag->id, 'transaction_journal_id' => $journal['transaction_journal_id']]);
app('log')->debug(sprintf('RuleAction AddTag. Added tag #%d ("%s") to journal %d.', $tag->id, $tag->tag, $journal['transaction_journal_id']));
/** @var TransactionJournal $object */
$object = TransactionJournal::find($journal['transaction_journal_id']);
// event for audit log entry

4
app/TransactionRules/Actions/ClearNotes.php
View File

@@ -26,7 +26,9 @@ namespace FireflyIII\TransactionRules\Actions;
use DB;
use FireflyIII\Events\Model\Rule\RuleActionFailedOnArray;
use FireflyIII\Events\TriggeredAuditLog;
use FireflyIII\Models\Note;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
/**
@@ -51,7 +53,9 @@ class ClearNotes implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var TransactionJournal $object */
$object = TransactionJournal::where('user_id', $journal['user_id'])->find($journal['transaction_journal_id']);
/** @var Note|null $notes */
$notes = $object->notes()->first();
if (null === $notes) {
app('log')->debug(sprintf('RuleAction ClearNotes, journal #%d has no notes.', $journal['transaction_journal_id']));

4
app/TransactionRules/Actions/DeleteTransaction.php
View File

@@ -63,6 +63,7 @@ class DeleteTransaction implements ActionInterface
$journal['description']
)
);
/** @var TransactionGroup $group */
$group = TransactionGroup::find($journal['transaction_group_id']);
$service = app(TransactionGroupDestroyService::class);
$service->destroy($group);
@@ -76,7 +77,8 @@ class DeleteTransaction implements ActionInterface
);
// trigger delete factory:
$object = TransactionJournal::find($journal['transaction_group_id']);
/** @var TransactionJournal|null $object */
$object = TransactionJournal::find($journal['transaction_journal_id']);
if (null !== $object) {
/** @var JournalDestroyService $service */
$service = app(JournalDestroyService::class);

2
app/TransactionRules/Actions/LinkToBill.php
View File

@@ -55,6 +55,7 @@ class LinkToBill implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var User $user */
$user = User::find($journal['user_id']);
/** @var BillRepositoryInterface $repository */
$repository = app(BillRepositoryInterface::class);
@@ -85,6 +86,7 @@ class LinkToBill implements ActionInterface
sprintf('RuleAction LinkToBill set the bill of journal #%d to bill #%d ("%s").', $journal['transaction_journal_id'], $bill->id, $bill->name)
);
/** @var TransactionJournal $object */
$object = TransactionJournal::where('user_id', $journal['user_id'])->find($journal['transaction_journal_id']);
event(new TriggeredAuditLog($this->action->rule, $object, 'set_bill', null, $bill->name));

1
app/TransactionRules/Actions/RemoveTag.php
View File

@@ -54,6 +54,7 @@ class RemoveTag implements ActionInterface
{
// if tag does not exist, no need to continue:
$name = $this->action->action_value;
/** @var User $user */
$user = User::find($journal['user_id']);
$tag = $user->tags()->where('tag', $name)->first();

1
app/TransactionRules/Actions/SetBudget.php
View File

@@ -53,6 +53,7 @@ class SetBudget implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var User $user */
$user = User::find($journal['user_id']);
$search = $this->action->action_value;

1
app/TransactionRules/Actions/SetCategory.php
View File

@@ -53,6 +53,7 @@ class SetCategory implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var User|null $user */
$user = User::find($journal['user_id']);
$search = $this->action->action_value;
if (null === $user) {

2
app/TransactionRules/Actions/SetDestinationAccount.php
View File

@@ -57,8 +57,8 @@ class SetDestinationAccount implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var User $user */
$user = User::find($journal['user_id']);
$type = $journal['transaction_type_type'];
/** @var TransactionJournal|null $object */
$object = $user->transactionJournals()->find((int)$journal['transaction_journal_id']);
$this->repository = app(AccountRepositoryInterface::class);

2
app/TransactionRules/Actions/SetSourceAccount.php
View File

@@ -57,8 +57,8 @@ class SetSourceAccount implements ActionInterface
*/
public function actOnArray(array $journal): bool
{
/** @var User $user */
$user = User::find($journal['user_id']);
$type = $journal['transaction_type_type'];
/** @var TransactionJournal|null $object */
$object = $user->transactionJournals()->find((int)$journal['transaction_journal_id']);
$this->repository = app(AccountRepositoryInterface::class);

1
app/TransactionRules/Actions/UpdatePiggybank.php
View File

@@ -59,6 +59,7 @@ class UpdatePiggybank implements ActionInterface
app('log')->debug(sprintf('Triggered rule action UpdatePiggybank on journal #%d', $journal['transaction_journal_id']));
// refresh the transaction type.
/** @var User $user */
$user = User::find($journal['user_id']);
/** @var TransactionJournal $journalObj */
$journalObj = $user->transactionJournals()->find($journal['transaction_journal_id']);