Various code cleaning things.

app/Helpers/Csv/Importer.php

@@ -371,8 +371,8 @@ class Importer
 
             /** @var Rule $rule */
             foreach ($group->rules as $rule) {
-                $processor = new Processor($rule, $journal);
+                $processor = Processor::make($rule);
-                $processor->handle();
+                $processor->handleTransactionJournal($journal);
                 if ($rule->stop_processing) {
                     break;
                 }

app/Http/Controllers/Auth/AuthController.php

@@ -97,6 +97,8 @@ class AuthController extends Controller
      * @param  \Illuminate\Http\Request $request
      *
      * @return \Illuminate\Http\Response
+     * @throws FireflyException
+     * @throws \Illuminate\Foundation\Validation\ValidationException
      */
     public function register(Request $request)
     {

app/Http/Controllers/HomeController.php

@@ -27,11 +27,6 @@ class HomeController extends Controller
         parent::__construct();
     }
 
-    public function displayError() {
-        throw new FireflyException('A very simple test error.');
-    }
-
-
     public function dateRange()
     {
         $start = new Carbon(Input::get('start'));
@@ -47,6 +42,11 @@ class HomeController extends Controller
         Session::put('end', $end);
     }
 
+    public function displayError()
+    {
+        throw new FireflyException('A very simple test error.');
+    }
+
     /**
      * @return \Illuminate\Http\RedirectResponse
      */

app/Http/Controllers/RuleController.php

@@ -139,7 +139,8 @@ class RuleController extends Controller
     }
 
     /**
-     * @param Rule $rule
+     * @param RuleRepositoryInterface $repository
+     * @param Rule                    $rule
      *
      * @return View
      */
@@ -174,6 +175,8 @@ class RuleController extends Controller
     }
 
     /**
+     * @param RuleGroupRepositoryInterface $repository
+     *
      * @return View
      */
     public function index(RuleGroupRepositoryInterface $repository)
@@ -263,6 +266,8 @@ class RuleController extends Controller
     }
 
     /**
+     * @param TestRuleFormRequest $request
+     *
      * @return \Illuminate\View\View
      */
     public function testTriggers(TestRuleFormRequest $request)

app/Models/Role.php

@@ -7,6 +7,11 @@ use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 
 
+/**
+ * Class Role
+ *
+ * @package FireflyIII\Models
+ */
 class Role extends Model
 {
 

app/Repositories/Account/AccountRepository.php

@@ -455,6 +455,7 @@ class AccountRepository implements AccountRepositoryInterface
      * @param array $data
      *
      * @return Account
+     * @throws FireflyException
      */
     private function storeAccount(array $data): Account
     {

app/Repositories/Journal/JournalRepository.php

@@ -112,6 +112,8 @@ class JournalRepository implements JournalRepositoryInterface
      * @param int   $offset
      * @param int   $page
      *
+     * @param int   $pagesize
+     *
      * @return LengthAwarePaginator
      */
     public function getJournalsOfTypes(array $types, int $offset, int $page, int $pagesize = 50)
@@ -347,7 +349,7 @@ class JournalRepository implements JournalRepositoryInterface
      * @param array           $data
      *
      * @return array
-     *
+     * @throws FireflyException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     protected function storeAccounts(TransactionType $type, array $data)

app/Rules/TransactionMatcher.php

@@ -36,9 +36,8 @@ class TransactionMatcher
     /**
      * Find matching transactions for the current set of triggers
      *
-     * @param int $maxResults The maximum number of transactions returned
-     *
      * @return array
+     *
      */
     public function findMatchingTransactions()
     {

app/Rules/Triggers/TriggerFactory.php

@@ -48,6 +48,8 @@ class TriggerFactory
      * @param string $triggerType
      * @param string $triggerValue
      *
+     * @param bool   $stopProcessing
+     *
      * @return AbstractTrigger
      * @throws FireflyException
      */

config/firefly.php

@@ -221,9 +221,9 @@ return [
     ],
     'test-triggers' => [
         // The maximum number of transactions shown when testing a list of triggers
-        'limit' => 10,
+        'limit' => 50,
         
         // The maximum number of transactions to analyse, when testing a list of triggers
-        'range' => 100
+        'range' => 1000
     ]
 ];