kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-14 16:13:54 +00:00
Code Issues Projects Releases Wiki Activity

use cases for rules tested.

Browse Source
This commit is contained in:
James Cole
2018-05-30 18:05:06 +02:00
parent dc77d8edda
commit b33ca786ae
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/TransactionRules/Actions/SetDestinationAccount.php
View File

@@ -102,6 +102,9 @@ class SetDestinationAccount implements ActionInterface
// update destination transaction with new destination account: // update destination transaction with new destination account:
// get destination transaction: // get destination transaction:
$transaction = $journal->transactions()->where('amount', '>', 0)->first(); $transaction = $journal->transactions()->where('amount', '>', 0)->first();
if(null === $transaction) {
return true;
}
$transaction->account_id = $this->newDestinationAccount->id; $transaction->account_id = $this->newDestinationAccount->id;
$transaction->save(); $transaction->save();
$journal->touch(); $journal->touch();
@@ -131,7 +134,7 @@ class SetDestinationAccount implements ActionInterface
/** /**
* *
*/ */
private function findExpenseAccount() private function findExpenseAccount(): void
{ {
$account = $this->repository->findByName($this->action->action_value, [AccountType::EXPENSE]); $account = $this->repository->findByName($this->action->action_value, [AccountType::EXPENSE]);
if (null === $account) { if (null === $account) {

14
tests/Unit/Factory/TransactionCurrencyFactoryTest.php
View File

@@ -92,6 +92,20 @@ class TransactionCurrencyFactoryTest extends TestCase
$this->assertEquals($currency->id, $result->id); $this->assertEquals($currency->id, $result->id);
} }
/**
* submit ID = 1000
*
* @covers \FireflyIII\Factory\TransactionCurrencyFactory
*/
public function testFindByBadID(): void
{
$currency = TransactionCurrency::inRandomOrder()->whereNull('deleted_at')->first();
/** @var TransactionCurrencyFactory $factory */
$factory = app(TransactionCurrencyFactory::class);
$result = $factory->find(1000, $currency->code);
$this->assertEquals($currency->id, $result->id);
}
/** /**
* @covers \FireflyIII\Factory\TransactionCurrencyFactory * @covers \FireflyIII\Factory\TransactionCurrencyFactory
*/ */