Fix phpstan issues.

2025-10-12 15:35:15 +00:00 · 2025-09-07 06:25:26 +02:00
parent bf53f5d6b7
commit b87b99a755
19 changed files with 81 additions and 115 deletions
--- a/app/Helpers/Attachments/AttachmentHelper.php
+++ b/app/Helpers/Attachments/AttachmentHelper.php
@@ -35,6 +35,8 @@ use Illuminate\Support\Facades\Crypt;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Storage;
 use Illuminate\Support\MessageBag;
+use Safe\Exceptions\FileinfoException;
+use Safe\Exceptions\FilesystemException;
 use Symfony\Component\HttpFoundation\File\UploadedFile;

 use function Safe\tmpfile;
@@ -126,9 +128,10 @@ class AttachmentHelper implements AttachmentHelperInterface
    public function saveAttachmentFromApi(Attachment $attachment, string $content): bool
    {
        Log::debug(sprintf('Now in %s', __METHOD__));
-        $resource             = tmpfile();
-        if (false === $resource) {
-            Log::error('Cannot create temp-file for file upload.');
+        try {
+            $resource = tmpfile();
+        } catch (FilesystemException $e) {
+            Log::error(sprintf('Cannot create temp-file for file upload: %s', $e->getMessage()));

            return false;
        }
@@ -141,17 +144,18 @@ class AttachmentHelper implements AttachmentHelperInterface

        $path                 = stream_get_meta_data($resource)['uri'];
        Log::debug(sprintf('Path is %s', $path));
-        $result               = fwrite($resource, $content);
-        if (false === $result) {
-            Log::error('Could not write temp file.');
+        try {
+            $result = fwrite($resource, $content);
+        } catch (FilesystemException $e) {
+            Log::error(sprintf('Could not write to temp file: %s', $e->getMessage()));

            return false;
        }
        Log::debug(sprintf('Wrote %d bytes to temp file.', $result));
-        $finfo                = finfo_open(FILEINFO_MIME_TYPE);
-        if (false === $finfo) {
-            Log::error('Could not open finfo.');
-            fclose($resource);
+        try {
+            $finfo = finfo_open(FILEINFO_MIME_TYPE);
+        } catch (FileinfoException $e) {
+            Log::error(sprintf('Could not open finfo handler: %s', $e->getMessage()));

            return false;
        }
@@ -171,7 +175,7 @@ class AttachmentHelper implements AttachmentHelperInterface
        $this->uploadDisk->put($file, $content);

        // update attachment.
-        $attachment->md5      = (string) md5_file($path);
+        $attachment->md5      =  md5_file($path);
        $attachment->mime     = $mime;
        $attachment->size     = strlen($content);
        $attachment->uploaded = true;
@@ -233,7 +237,7 @@ class AttachmentHelper implements AttachmentHelperInterface
            $attachment           = new Attachment(); // create Attachment object.
            $attachment->user()->associate($user);
            $attachment->attachable()->associate($model);
-            $attachment->md5      = (string) md5_file($file->getRealPath());
+            $attachment->md5      =  md5_file($file->getRealPath());
            $attachment->filename = $file->getClientOriginalName();
            $attachment->mime     = $file->getMimeType();
            $attachment->size     = $file->getSize();
--- a/app/Helpers/Collector/Extensions/MetaCollection.php
+++ b/app/Helpers/Collector/Extensions/MetaCollection.php
@@ -199,7 +199,7 @@ trait MetaCollection

    public function excludeInternalReference(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -220,7 +220,7 @@ trait MetaCollection

    public function externalIdContains(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -232,7 +232,7 @@ trait MetaCollection

    public function externalIdDoesNotContain(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -244,7 +244,7 @@ trait MetaCollection

    public function externalIdDoesNotEnd(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -256,7 +256,7 @@ trait MetaCollection

    public function externalIdDoesNotStart(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -268,7 +268,7 @@ trait MetaCollection

    public function externalIdEnds(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -280,7 +280,7 @@ trait MetaCollection

    public function externalIdStarts(string $externalId): GroupCollectorInterface
    {
-        $externalId = (string) json_encode($externalId);
+        $externalId = json_encode($externalId);
        $externalId = str_replace('\\', '\\\\', trim($externalId, '"'));

        $this->joinMetaDataTables();
@@ -293,7 +293,7 @@ trait MetaCollection
    public function externalUrlContains(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', trim($url, '"'));
        $this->query->where('journal_meta.name', '=', 'external_url');
        $this->query->whereLike('journal_meta.data', sprintf('%%%s%%', $url));
@@ -304,7 +304,7 @@ trait MetaCollection
    public function externalUrlDoesNotContain(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', trim($url, '"'));
        $this->query->where('journal_meta.name', '=', 'external_url');
        $this->query->whereNotLike('journal_meta.data', sprintf('%%%s%%', $url));
@@ -315,7 +315,7 @@ trait MetaCollection
    public function externalUrlDoesNotEnd(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', ltrim($url, '"'));
        $this->query->where('journal_meta.name', '=', 'external_url');
        $this->query->whereNotLike('journal_meta.data', sprintf('%%%s', $url));
@@ -326,7 +326,7 @@ trait MetaCollection
    public function externalUrlDoesNotStart(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', rtrim($url, '"'));
        // var_dump($url);

@@ -339,7 +339,7 @@ trait MetaCollection
    public function externalUrlEnds(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', ltrim($url, '"'));
        $this->query->where('journal_meta.name', '=', 'external_url');
        $this->query->whereLike('journal_meta.data', sprintf('%%%s', $url));
@@ -350,7 +350,7 @@ trait MetaCollection
    public function externalUrlStarts(string $url): GroupCollectorInterface
    {
        $this->joinMetaDataTables();
-        $url = (string) json_encode($url);
+        $url = json_encode($url);
        $url = str_replace('\\', '\\\\', rtrim($url, '"'));
        // var_dump($url);

@@ -401,7 +401,7 @@ trait MetaCollection

    public function internalReferenceContains(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));
        // var_dump($internalReference);
        // exit;
@@ -416,7 +416,7 @@ trait MetaCollection

    public function internalReferenceDoesNotContain(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -429,7 +429,7 @@ trait MetaCollection

    public function internalReferenceDoesNotEnd(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -442,7 +442,7 @@ trait MetaCollection

    public function internalReferenceDoesNotStart(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -455,7 +455,7 @@ trait MetaCollection

    public function internalReferenceEnds(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -468,7 +468,7 @@ trait MetaCollection

    public function internalReferenceStarts(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
@@ -724,7 +724,7 @@ trait MetaCollection

    public function setInternalReference(string $internalReference): GroupCollectorInterface
    {
-        $internalReference = (string) json_encode($internalReference);
+        $internalReference = json_encode($internalReference);
        $internalReference = str_replace('\\', '\\\\', trim($internalReference, '"'));

        $this->joinMetaDataTables();
--- a/app/Helpers/Report/NetWorth.php
+++ b/app/Helpers/Report/NetWorth.php
@@ -51,7 +51,7 @@ class NetWorth implements NetWorthInterface
    private AccountRepositoryInterface  $accountRepository;
    private CurrencyRepositoryInterface $currencyRepos;
    private User                        $user;             // @phpstan-ignore-line
-    private ?UserGroup                  $userGroup = null; // @phpstan-ignore-line
+    private ?UserGroup                  $userGroup = null;

    /**
     * This method collects the user's net worth in ALL the user's currencies