kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 20:16:22 +00:00
Code Issues Projects Releases Wiki Activity

Fix account API tests.

Browse Source
This commit is contained in:
James Cole
2021-03-13 13:26:45 +01:00
parent 7118abe28d
commit bd040c80b2
5 changed files with 388 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
tests/Api/Models/Account/StoreControllerTest.php
View File

@@ -50,15 +50,29 @@ class StoreControllerTest extends TestCase
/**
* @param array $submission
*
* @dataProvider storeAccountDataProvider
* X data Provider storeAccountDataProvider
*
* @dataProvider emptyDataProvider
*/
public function testStore(array $submission): void
{
if ([] === $submission) {
$this->markTestSkipped('Empty data provider');
}
// run account store with a minimal data set:
$route = 'api.v1.accounts.store';
$this->submitAndCompare($route, $submission);
}
/**
* @return array
*/
public function emptyDataProvider(): array
{
return [[[]]];
}
/**
* @return array
*/
@@ -102,69 +116,69 @@ class StoreControllerTest extends TestCase
$rand = rand(1, 4);
return [
'active' => [
'active' => [
'fields' => [
'active' => $faker->boolean,
],
],
// 'iban' => [
// 'fields' => [
// 'iban' => $faker->iban(),
// ],
// ],
// 'bic' => [
// 'fields' => [
// 'bic' => $faker->swiftBicNumber,
// ],
// ],
// 'account_number' => [
// 'fields' => [
// 'account_number' => $faker->iban(),
// ],
// ],
// 'ob' => [
// 'fields' => [
// 'opening_balance' => $this->getRandomAmount(),
// 'opening_balance_date' => $this->getRandomDateString(),
// ],
// ],
// 'virtual_balance' => [
// 'fields' => [
// 'virtual_balance' => $this->getRandomAmount(),
// ],
// ],
// 'currency_id' => [
// 'fields' => [
// 'currency_id' => $rand,
// ],
// ],
// 'currency_code' => [
// 'fields' => [
// 'currency_code' => $currencies[$rand],
// ],
// ],
// 'order' => [
// 'fields' => [
// 'order' => $faker->numberBetween(1, 5),
// ],
// ],
// 'include_net_worth' => [
// 'fields' => [
// 'include_net_worth' => $faker->boolean,
// ],
// ],
// 'notes' => [
// 'fields' => [
// 'notes' => join(' ', $faker->words(5)),
// ],
// ],
// 'location' => [
// 'fields' => [
// 'latitude' => $faker->latitude,
// 'longitude' => $faker->longitude,
// 'zoom_level' => $faker->numberBetween(1, 10),
// ],
// ],
// 'iban' => [
// 'fields' => [
// 'iban' => $faker->iban(),
// ],
// ],
// 'bic' => [
// 'fields' => [
// 'bic' => $faker->swiftBicNumber,
// ],
// ],
// 'account_number' => [
// 'fields' => [
// 'account_number' => $faker->iban(),
// ],
// ],
// 'ob' => [
// 'fields' => [
// 'opening_balance' => $this->getRandomAmount(),
// 'opening_balance_date' => $this->getRandomDateString(),
// ],
// ],
// 'virtual_balance' => [
// 'fields' => [
// 'virtual_balance' => $this->getRandomAmount(),
// ],
// ],
// 'currency_id' => [
// 'fields' => [
// 'currency_id' => $rand,
// ],
// ],
// 'currency_code' => [
// 'fields' => [
// 'currency_code' => $currencies[$rand],
// ],
// ],
// 'order' => [
// 'fields' => [
// 'order' => $faker->numberBetween(1, 5),
// ],
// ],
// 'include_net_worth' => [
// 'fields' => [
// 'include_net_worth' => $faker->boolean,
// ],
// ],
// 'notes' => [
// 'fields' => [
// 'notes' => join(' ', $faker->words(5)),
// ],
// ],
// 'location' => [
// 'fields' => [
// 'latitude' => $faker->latitude,
// 'longitude' => $faker->longitude,
// 'zoom_level' => $faker->numberBetween(1, 10),
// ],
// ],
];
}

192
tests/Api/Models/Account/UpdateControllerTest.php
View File

@@ -22,9 +22,13 @@
namespace Tests\Api\Models\Account;
use Faker\Factory;
use Laravel\Passport\Passport;
use Tests\TestCase;
use Log;
use Tests\TestCase;
use Tests\Traits\CollectsValues;
use Tests\Traits\RandomValues;
use Tests\Traits\TestHelpers;
/**
@@ -32,6 +36,8 @@ use Log;
*/
class UpdateControllerTest extends TestCase
{
use RandomValues, TestHelpers, CollectsValues;
/**
*
*/
@@ -43,10 +49,190 @@ class UpdateControllerTest extends TestCase
}
/**
*
* @dataProvider updateSetDataProvider
*/
public function testUpdate(): void {
public function testUpdate(array $submission): void
{
$ignore = [
'created_at',
'updated_at',
'currency_code',
'currency_symbol',
'currency_decimal_places',
'current_balance',
];
$route = route('api.v1.accounts.update', [$submission['id']]);
$this->updateAndCompare($route, $submission, $ignore);
}
/**
* @return array
*/
public function updateSetDataProvider(): array
{
$submissions = [];
$all = $this->updateDataSet();
foreach ($all as $name => $data) {
$submissions[] = [$data];
}
return $submissions;
}
/**
* @return array
*/
public function updateDataSet(): array
{
$faker = Factory::create();
$currencies = ['EUR', 'GBP', 'USD', 'HUF'];
$currencyCode = $currencies[rand(0, count($currencies) - 1)];
$accountRoles = ['defaultAsset', 'sharedAsset', 'savingAsset'];
$accountRole = $accountRoles[rand(0, count($accountRoles) - 1)];
$liabilityRoles = ['loan', 'debt', 'asset'];
$liabilityRole = $liabilityRoles[rand(0, count($liabilityRoles) - 1)];
$interestPeriods = ['daily', 'monthly', 'yearly'];
$interestPeriod = $interestPeriods[rand(0, count($interestPeriods) - 1)];
$set = [
'name' => [
'id' => 1,
'fields' => [
'name' => ['test_value' => $faker->text(64)],
],
'extra_ignore' => [],
],
'active' => [
'id' => 1,
'fields' => [
'active' => ['test_value' => $faker->boolean],
],
'extra_ignore' => [],
],
'iban' => [
'id' => 1,
'fields' => [
'iban' => ['test_value' => $faker->iban()],
],
'extra_ignore' => [],
],
'bic' => [
'id' => 1,
'fields' => [
'bic' => ['test_value' => $faker->swiftBicNumber],
],
'extra_ignore' => [],
],
'account_number' => [
'id' => 1,
'fields' => [
'account_number' => ['test_value' => $faker->iban()],
],
'extra_ignore' => [],
],
'order' => [
'id' => 1,
'fields' => [
'order' => ['test_value' => $faker->numberBetween(1, 10)],
],
'extra_ignore' => [],
],
'include_net_worth' => [
'id' => 1,
'fields' => [
'include_net_worth' => ['test_value' => $faker->boolean],
],
'extra_ignore' => [],
],
'virtual_balance' => [
'id' => 1,
'fields' => [
'virtual_balance' => ['test_value' => number_format($faker->randomFloat(2,10,100), 2)],
],
'extra_ignore' => [],
],
'currency_id' => [
'id' => 1,
'fields' => [
'currency_id' => ['test_value' => (string)$faker->numberBetween(1, 10)],
],
'extra_ignore' => [],
],
'currency_code' => [
'id' => 1,
'fields' => [
'currency_code' => ['test_value' => $currencyCode],
],
'extra_ignore' => [],
],
'account_role' => [
'id' => 1,
'fields' => [
'account_role' => ['test_value' => $accountRole],
],
'extra_ignore' => [],
],
'notes' => [
'id' => 1,
'fields' => [
'notes' => ['test_value' => $faker->randomAscii],
],
'extra_ignore' => [],
],
'location' => [
'id' => 1,
'fields' => [
'longitude' => ['test_value' => $faker->longitude],
'latitude' => ['test_value' => $faker->latitude],
'zoom_level' => ['test_value' => $faker->numberBetween(1, 10)],
],
'extra_ignore' => [],
],
'ob' => [
'id' => 1,
'fields' => [
'opening_balance' => ['test_value' => number_format($faker->randomFloat(2,10,100), 2)],
'opening_balance_date' => ['test_value' => $faker->date('Y-m-d')],
],
'extra_ignore' => [],
],
'cc2' => [
'id' => 7,
'fields' => [
'monthly_payment_date' => ['test_value' => $faker->date('Y-m-d')],
],
'extra_ignore' => [],
],
'cc3' => [
'id' => 7,
'fields' => [
'monthly_payment_date' => ['test_value' => $faker->date('Y-m-d')],
'credit_card_type' => ['test_value' => 'monthlyFull'],
],
'extra_ignore' => [],
],
'liabilityA' => [
'id' => 13,
'fields' => [
'liability_type' => ['test_value' => $liabilityRole],
],
'extra_ignore' => [],
],
'liabilityB' => [
'id' => 13,
'fields' => [
'interest' => ['test_value' => $faker->randomFloat(2, 1, 99)],
'interest_period' => ['test_value' => $interestPeriod],
],
'extra_ignore' => [],
],
];
return $set;
}