Fix unit tests.

app/Console/Commands/CreateExport.php

@@ -65,7 +65,9 @@ class CreateExport extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function handle(): int
     {

app/Console/Commands/DecryptAttachment.php

@@ -51,8 +51,12 @@ class DecryptAttachment extends Command
 
     /**
      * Execute the console command.
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     *
+     * @return int
      */
-    public function handle(): void
+    public function handle(): int
     {
         /** @var AttachmentRepositoryInterface $repository */
         $repository     = app(AttachmentRepositoryInterface::class);
@@ -64,28 +68,28 @@ class DecryptAttachment extends Command
             $this->error(sprintf('No attachment with id #%d', $attachmentId));
             Log::error(sprintf('DecryptAttachment: No attachment with id #%d', $attachmentId));
 
-            return;
+            return 1;
         }
 
         if ($attachmentName !== $attachment->filename) {
             $this->error('File name does not match.');
             Log::error('DecryptAttachment: File name does not match.');
 
-            return;
+            return 1;
         }
 
         if (!is_dir($storagePath)) {
             $this->error(sprintf('Path "%s" is not a directory.', $storagePath));
             Log::error(sprintf('DecryptAttachment: Path "%s" is not a directory.', $storagePath));
 
-            return;
+            return 1;
         }
 
         if (!is_writable($storagePath)) {
             $this->error(sprintf('Path "%s" is not writable.', $storagePath));
             Log::error(sprintf('DecryptAttachment: Path "%s" is not writable.', $storagePath));
 
-            return;
+            return 1;
         }
 
         $fullPath = $storagePath . DIRECTORY_SEPARATOR . $attachment->filename;
@@ -95,9 +99,10 @@ class DecryptAttachment extends Command
         if (false === $result) {
             $this->error('Could not write to file.');
 
-            return;
+            return 1;
         }
         $this->info(sprintf('%d bytes written. Exiting now..', $result));
 
+        return 0;
     }
 }

tests/Unit/TransactionRules/Triggers/ToAccountContainsTest.php

@@ -36,9 +36,16 @@ class ToAccountContainsTest extends TestCase
      */
     public function testTriggered(): void
     {
+        $count = 0;
+        do {
             $journal          = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
             $transaction      = $journal->transactions()->where('amount', '>', 0)->first();
-        $account     = $transaction->account;
+            $transactionCount = $journal->transactions()->count();
+            $account          = null === $transaction ? null : $transaction->account;
+            $count++;
+        } while ($account === null && $count < 30 && $transactionCount !== 2);
+
+
         $trigger = ToAccountContains::makeFromStrings($account->name, false);
         $result  = $trigger->triggered($journal);
         $this->assertTrue($result);
@@ -49,7 +56,16 @@ class ToAccountContainsTest extends TestCase
      */
     public function testTriggeredNot(): void
     {
+        $count = 0;
+        do {
             $journal          = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
+            $transaction      = $journal->transactions()->where('amount', '>', 0)->first();
+            $transactionCount = $journal->transactions()->count();
+            $account          = null === $transaction ? null : $transaction->account;
+            $count++;
+        } while ($account === null && $count < 30 && $transactionCount !== 2);
+
+
         $trigger = ToAccountContains::makeFromStrings('some name' . random_int(1, 234), false);
         $result  = $trigger->triggered($journal);
         $this->assertFalse($result);

tests/Unit/TransactionRules/Triggers/ToAccountIsTest.php

@@ -41,7 +41,7 @@ class ToAccountIsTest extends TestCase
             $journal          = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
             $transaction      = $journal->transactions()->where('amount', '>', 0)->first();
             $transactionCount = $journal->transactions()->count();
-            $account          = $transaction->account;
+            $account          = null === $transaction ? null : $transaction->account;
             $count++;
         } while ($account === null && $count < 30 && $transactionCount !== 2);
 
@@ -60,7 +60,7 @@ class ToAccountIsTest extends TestCase
             $journal          = TransactionJournal::inRandomOrder()->whereNull('deleted_at')->first();
             $transaction      = $journal->transactions()->where('amount', '>', 0)->first();
             $transactionCount = $journal->transactions()->count();
-            $account          = $transaction->account;
+            $account          = null === $transaction ? null : $transaction->account;
             $count++;
         } while ($account === null && $count < 30 && $transactionCount !== 2);
 

tests/Unit/TransactionRules/Triggers/ToAccountStartsTest.php

@@ -46,7 +46,7 @@ class ToAccountStartsTest extends TestCase
             $journal     = $this->user()->transactionJournals()->inRandomOrder()->whereNull('deleted_at')->first();
             $count       = $journal->transactions()->where('amount', '>', 0)->count();
             $transaction = $journal->transactions()->where('amount', '>', 0)->first();
-            $account     = $transaction->account;
+            $account     = null === $transaction ? null : $transaction->account;
             Log::debug(sprintf('Journal with id #%d', $journal->id));
             Log::debug(sprintf('Count of transactions is %d', $count));
             Log::debug(sprintf('Account is null: %s', var_export(null === $account, true)));
@@ -71,7 +71,7 @@ class ToAccountStartsTest extends TestCase
             $journal     = $this->user()->transactionJournals()->inRandomOrder()->whereNull('deleted_at')->first();
             $count       = $journal->transactions()->where('amount', '>', 0)->count();
             $transaction = $journal->transactions()->where('amount', '>', 0)->first();
-            $account     = $transaction->account;
+            $account     = null === $transaction ? null : $transaction->account;
             Log::debug(sprintf('Journal with id #%d', $journal->id));
             Log::debug(sprintf('Count of transactions is %d', $count));
             Log::debug(sprintf('Account is null: %s', var_export(null === $account, true)));