From c02ab6f6d89af62163545a25aa43029440bddc0e Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 9 Jun 2019 10:27:11 +0200 Subject: [PATCH] Fix route calls [skip ci] --- tests/Api/V1/Controllers/BudgetLimitControllerTest.php | 2 +- tests/Api/V1/Controllers/CurrencyControllerTest.php | 4 ++-- tests/Api/V1/Controllers/LinkTypeControllerTest.php | 6 +++--- tests/Api/V1/Controllers/PiggyBankControllerTest.php | 2 +- tests/Api/V1/Controllers/PreferencesControllerTest.php | 9 +++++---- tests/Api/V1/Controllers/RecurrenceControllerTest.php | 2 +- .../Api/V1/Controllers/TransactionLinkControllerTest.php | 6 +++--- tests/Api/V1/Controllers/UserControllerTest.php | 2 +- 8 files changed, 17 insertions(+), 16 deletions(-) diff --git a/tests/Api/V1/Controllers/BudgetLimitControllerTest.php b/tests/Api/V1/Controllers/BudgetLimitControllerTest.php index 40086bf74a..b1c4bf1584 100644 --- a/tests/Api/V1/Controllers/BudgetLimitControllerTest.php +++ b/tests/Api/V1/Controllers/BudgetLimitControllerTest.php @@ -163,7 +163,7 @@ class BudgetLimitControllerTest extends TestCase $repository->shouldReceive('setUser')->once(); // call API - $response = $this->put('/api/v1/budgets/limits/' . $budgetLimit->id, $data); + $response = $this->put(route('api.v1.budget_limits.update', [$budgetLimit->id]), $data); $response->assertStatus(200); $response->assertHeader('Content-Type', 'application/vnd.api+json'); diff --git a/tests/Api/V1/Controllers/CurrencyControllerTest.php b/tests/Api/V1/Controllers/CurrencyControllerTest.php index 1744ae8864..1cf178a9b4 100644 --- a/tests/Api/V1/Controllers/CurrencyControllerTest.php +++ b/tests/Api/V1/Controllers/CurrencyControllerTest.php @@ -171,7 +171,7 @@ class CurrencyControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/currencies/' . $currency->code, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.currencies.update', [$currency->code]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertJson(['data' => ['type' => 'currencies', 'links' => true],]); $response->assertHeader('Content-Type', 'application/vnd.api+json'); @@ -216,7 +216,7 @@ class CurrencyControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/currencies/' . $currency->code, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.currencies.update', [$currency->code]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertJson(['data' => ['type' => 'currencies', 'links' => true],]); $response->assertHeader('Content-Type', 'application/vnd.api+json'); diff --git a/tests/Api/V1/Controllers/LinkTypeControllerTest.php b/tests/Api/V1/Controllers/LinkTypeControllerTest.php index 90839332e4..a7557f0a53 100644 --- a/tests/Api/V1/Controllers/LinkTypeControllerTest.php +++ b/tests/Api/V1/Controllers/LinkTypeControllerTest.php @@ -168,7 +168,7 @@ class LinkTypeControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/link_types/' . $linkType->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.link_types.update', [$linkType->id]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertHeader('Content-Type', 'application/vnd.api+json'); } @@ -206,7 +206,7 @@ class LinkTypeControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/link_types/' . $linkType->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.link_types.update', [$linkType->id]), $data, ['Accept' => 'application/json']); $response->assertStatus(500); $response->assertSee('You cannot edit this link type '); } @@ -247,7 +247,7 @@ class LinkTypeControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/link_types/' . $linkType->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.link_types.update', [$linkType->id]), $data, ['Accept' => 'application/json']); $response->assertStatus(500); $response->assertSee('You need the \"owner\"-role to do this.'); } diff --git a/tests/Api/V1/Controllers/PiggyBankControllerTest.php b/tests/Api/V1/Controllers/PiggyBankControllerTest.php index a559b7f34b..8d76ad3286 100644 --- a/tests/Api/V1/Controllers/PiggyBankControllerTest.php +++ b/tests/Api/V1/Controllers/PiggyBankControllerTest.php @@ -163,7 +163,7 @@ class PiggyBankControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/piggy_banks/' . $piggy->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.piggy_banks.update', [$piggy->id]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertJson(['data' => ['type' => 'piggy_banks', 'links' => true],]); $response->assertHeader('Content-Type', 'application/vnd.api+json'); diff --git a/tests/Api/V1/Controllers/PreferencesControllerTest.php b/tests/Api/V1/Controllers/PreferencesControllerTest.php index 176b2cafe7..c8950708fc 100644 --- a/tests/Api/V1/Controllers/PreferencesControllerTest.php +++ b/tests/Api/V1/Controllers/PreferencesControllerTest.php @@ -67,7 +67,7 @@ class PreferencesControllerTest extends TestCase /** @var Preference $preference */ $preference = Preferences::setForUser($this->user(), 'frontPageAccounts', [1, 2, 3]); $data = ['data' => '4,5,6']; - $response = $this->put('/api/v1/preferences/' . $preference->name, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.preferences.update', [$preference->name]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); } @@ -89,7 +89,8 @@ class PreferencesControllerTest extends TestCase /** @var Preference $preference */ $preference = Preferences::setForUser($this->user(), 'twoFactorAuthEnabled', false); $data = ['data' => '1']; - $response = $this->put('/api/v1/preferences/' . $preference->name, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.preferences.update', [$preference->name]), $data, ['Accept' => 'application/json']); + $response->assertStatus(200); } @@ -111,7 +112,7 @@ class PreferencesControllerTest extends TestCase /** @var Preference $preference */ $preference = Preferences::setForUser($this->user(), 'currencyPreference', false); $data = ['data' => 'EUR']; - $response = $this->put('/api/v1/preferences/' . $preference->name, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.preferences.update', [$preference->name]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); } @@ -133,7 +134,7 @@ class PreferencesControllerTest extends TestCase /** @var Preference $preference */ $preference = Preferences::setForUser($this->user(), 'listPageSize', 13); $data = ['data' => '434']; - $response = $this->put('/api/v1/preferences/' . $preference->name, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.preferences.update', [$preference->name]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); } diff --git a/tests/Api/V1/Controllers/RecurrenceControllerTest.php b/tests/Api/V1/Controllers/RecurrenceControllerTest.php index 60ef4100ec..064b7b5850 100644 --- a/tests/Api/V1/Controllers/RecurrenceControllerTest.php +++ b/tests/Api/V1/Controllers/RecurrenceControllerTest.php @@ -1455,7 +1455,7 @@ class RecurrenceControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/recurrences/' . $recurrence->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.recurrences.update', [$recurrence->id]), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertHeader('Content-Type', 'application/vnd.api+json'); } diff --git a/tests/Api/V1/Controllers/TransactionLinkControllerTest.php b/tests/Api/V1/Controllers/TransactionLinkControllerTest.php index ccea6814a4..0afd78c2e2 100644 --- a/tests/Api/V1/Controllers/TransactionLinkControllerTest.php +++ b/tests/Api/V1/Controllers/TransactionLinkControllerTest.php @@ -342,7 +342,7 @@ class TransactionLinkControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/transaction_links/' . $journalLink->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.transaction_links.update', $journalLink->id), $data, ['Accept' => 'application/json']); $response->assertStatus(200); $response->assertHeader('Content-Type', 'application/vnd.api+json'); } @@ -381,7 +381,7 @@ class TransactionLinkControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/transaction_links/' . $journalLink->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.transaction_links.update', $journalLink->id), $data, ['Accept' => 'application/json']); $response->assertStatus(500); $response->assertSee('Source or destination is NULL.'); // the creation moment. $response->assertHeader('Content-Type', 'application/json'); @@ -418,7 +418,7 @@ class TransactionLinkControllerTest extends TestCase ]; // test API - $response = $this->put('/api/v1/transaction_links/' . $journalLink->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.transaction_links.update', $journalLink->id), $data, ['Accept' => 'application/json']); $response->assertStatus(422); $response->assertSee('Invalid inward ID.'); // the creation moment. $response->assertHeader('Content-Type', 'application/json'); diff --git a/tests/Api/V1/Controllers/UserControllerTest.php b/tests/Api/V1/Controllers/UserControllerTest.php index c8ae0e180e..d55eef6413 100644 --- a/tests/Api/V1/Controllers/UserControllerTest.php +++ b/tests/Api/V1/Controllers/UserControllerTest.php @@ -207,7 +207,7 @@ class UserControllerTest extends TestCase $transformer->shouldReceive('transform')->atLeast()->once()->andReturn(['id' => 5]); // call API - $response = $this->put('/api/v1/users/' . $user->id, $data, ['Accept' => 'application/json']); + $response = $this->put(route('api.v1.users.update', $user->id), $data, ['Accept' => 'application/json']); $response->assertStatus(200); }