kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 23:45:10 +00:00
Code Issues Projects Releases Wiki Activity

Various phpstan fixes [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-01-04 08:42:06 +01:00
parent d4942efd8e
commit c43b37baef
34 changed files with 43 additions and 1229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
app/Support/Models/AccountBalanceCalculator.php
View File

@@ -156,7 +156,7 @@ class AccountBalanceCalculator
* @var array $currencies
*/
foreach ($balances as $accountId => $currencies) {
/** @var Account $account */
/** @var Account|null $account */
$account = Account::find($accountId);
if (null === $account) {
Log::error(sprintf('Could not find account #%d, will not save account balance.', $accountId));
@@ -169,7 +169,7 @@ class AccountBalanceCalculator
* @var array $balance
*/
foreach ($currencies as $currencyId => $balance) {
/** @var TransactionCurrency $currency */
/** @var TransactionCurrency|null $currency */
$currency = TransactionCurrency::find($currencyId);
if (null === $currency) {
Log::error(sprintf('Could not find currency #%d, will not save account balance.', $currencyId));
@@ -208,43 +208,4 @@ class AccountBalanceCalculator
$object->optimizedCalculation($accounts, $transactionJournal->date);
}
private function getAccountBalanceByAccount(int $account, int $currency): AccountBalance
{
$query = AccountBalance::where('title', 'balance')->where('account_id', $account)->where('transaction_currency_id', $currency);
$entry = $query->first();
if (null !== $entry) {
// Log::debug(sprintf('Found account balance "balance" for account #%d and currency #%d: %s', $account, $currency, $entry->balance));
return $entry;
}
$entry = new AccountBalance();
$entry->title = 'balance';
$entry->account_id = $account;
$entry->transaction_currency_id = $currency;
$entry->balance = '0';
$entry->save();
// Log::debug(sprintf('Created new account balance for account #%d and currency #%d: %s', $account, $currency, $entry->balance));
return $entry;
}
private function getAccountBalanceByJournal(string $title, int $account, int $journal, int $currency): AccountBalance
{
$query = AccountBalance::where('title', $title)->where('account_id', $account)->where('transaction_journal_id', $journal)->where('transaction_currency_id', $currency);
$entry = $query->first();
if (null !== $entry) {
return $entry;
}
$entry = new AccountBalance();
$entry->title = $title;
$entry->account_id = $account;
$entry->transaction_journal_id = $journal;
$entry->transaction_currency_id = $currency;
$entry->balance = '0';
$entry->save();
return $entry;
}
}