Sharper spent in period. [skip ci]

This commit is contained in:
James Cole
2016-05-20 18:29:51 +02:00
parent a5d5f86aed
commit c4818334e7
2 changed files with 10 additions and 2 deletions

View File

@@ -127,6 +127,8 @@ class AccountRepository implements AccountRepositoryInterface
$join->on('destination.transaction_journal_id', '=', 'transaction_journals.id')->where('destination.amount', '>', 0);
}
);
// should this not be a XOR query?
$query->whereIn('destination.account_id', $accountIds);
}
@@ -559,7 +561,13 @@ class AccountRepository implements AccountRepositoryInterface
$join->on('source.transaction_journal_id', '=', 'transaction_journals.id')->where('source.amount', '<', 0);
}
);
$query->leftJoin(
'transactions as destination', function (JoinClause $join) {
$join->on('destination.transaction_journal_id', '=', 'transaction_journals.id')->where('destination.amount', '>', 0);
}
);
$query->whereIn('source.account_id', $accountIds);
$query->whereNotIn('destination.account_id', $accountIds);
}
// remove group by