kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-17 02:05:34 +00:00
Code Issues Projects Releases Wiki Activity

Small code cleanup.

Browse Source
This commit is contained in:
James Cole
2025-02-09 07:10:05 +01:00
parent 6172d60e00
commit c61389037d
4 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Handlers/Observer/AccountObserver.php
View File

@@ -82,6 +82,7 @@ class AccountObserver
foreach ($account->piggyBanks()->get() as $piggy) { foreach ($account->piggyBanks()->get() as $piggy) {
$piggy->accounts()->detach($account); $piggy->accounts()->detach($account);
} }
/** @var Attachment $attachment */ /** @var Attachment $attachment */
foreach ($account->attachments()->get() as $attachment) { foreach ($account->attachments()->get() as $attachment) {
$repository->destroy($attachment); $repository->destroy($attachment);

1
app/Handlers/Observer/TransactionJournalObserver.php
View File

@@ -46,6 +46,7 @@ class TransactionJournalObserver
$transaction->delete(); $transaction->delete();
} }
}); });
/** @var Attachment $attachment */ /** @var Attachment $attachment */
foreach ($transactionJournal->attachments()->get() as $attachment) { foreach ($transactionJournal->attachments()->get() as $attachment) {
$repository->destroy($attachment); $repository->destroy($attachment);

2
app/Support/Search/QueryParser/Node.php
View File

@@ -66,6 +66,7 @@ abstract class Node
if ($compare instanceof NodeGroup && $this instanceof NodeGroup) { if ($compare instanceof NodeGroup && $this instanceof NodeGroup) {
if (count($compare->getNodes()) !== count($this->getNodes())) { if (count($compare->getNodes()) !== count($this->getNodes())) {
Log::debug(sprintf('Return false because node count is different. Original is %d, compare is %d', count($this->getNodes()), count($compare->getNodes()))); Log::debug(sprintf('Return false because node count is different. Original is %d, compare is %d', count($this->getNodes()), count($compare->getNodes())));
return false; return false;
} }
@@ -76,6 +77,7 @@ abstract class Node
foreach ($this->getNodes() as $index => $node) { foreach ($this->getNodes() as $index => $node) {
if (false === $node->equals($compare->getNodes()[$index])) { if (false === $node->equals($compare->getNodes()[$index])) {
Log::debug('Return false because nodes are different!'); Log::debug('Return false because nodes are different!');
return false; return false;
} }
} }

2
app/Support/Twig/AmountFormat.php
View File

@@ -114,7 +114,7 @@ class AmountFormat extends AbstractExtension
static function (string $amount, string $code, ?bool $coloured = null): string { static function (string $amount, string $code, ?bool $coloured = null): string {
$coloured ??= true; $coloured ??= true;
/** @var TransactionCurrency|null $currency */ /** @var null|TransactionCurrency $currency */
$currency = TransactionCurrency::whereCode($code)->first(); $currency = TransactionCurrency::whereCode($code)->first();
if (null === $currency) { if (null === $currency) {
Log::error(sprintf('Could not find currency with code "%s". Fallback to native currency.', $code)); Log::error(sprintf('Could not find currency with code "%s". Fallback to native currency.', $code));