kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-16 09:22:33 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-06-13 07:04:18 +02:00
parent 85204de9aa
commit c98706fac0
24 changed files with 39 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Http/Controllers/Admin/UpdateController.php
View File

@@ -100,10 +100,6 @@ class UpdateController extends Controller
$channel = $request->get('update_channel');
$channel = in_array($channel, ['stable', 'beta', 'alpha'], true) ? $channel : 'stable';
// store as telemetry
app('telemetry')->feature('admin.update.channel', $channel);
app('telemetry')->feature('admin.update.permission', (string)$checkForUpdates);
app('fireflyconfig')->set('permission_update_check', $checkForUpdates);
app('fireflyconfig')->set('last_update_check', time());
app('fireflyconfig')->set('update_channel', $channel);

3
app/Http/Controllers/Auth/RegisterController.php
View File

@@ -112,9 +112,6 @@ class RegisterController extends Controller
$this->registered($request, $user);
// telemetry
app('telemetry')->feature('system.users.count', (string)User::count());
return redirect($this->redirectPath());
}

2
app/Http/Controllers/Chart/ExpenseReportController.php
View File

@@ -187,7 +187,7 @@ class ExpenseReportController extends Controller
$newSet[$key] = $entry;
}
}
if (0===count($newSet)) {
if (empty($newSet)) {
$newSet = $chartData;
}
$data = $this->generator->multiSet($newSet);

2
app/Http/Controllers/Json/BoxController.php
View File

@@ -189,7 +189,7 @@ class BoxController extends Controller
$incomes[$currencyId] = app('amount')->formatAnything($currency, $incomes[$currencyId] ?? '0', false);
$expenses[$currencyId] = app('amount')->formatAnything($currency, $expenses[$currencyId] ?? '0', false);
}
if (0===count($sums)) {
if (empty($sums)) {
$currency = app('amount')->getDefaultCurrency();
$sums[$currency->id] = app('amount')->formatAnything($currency, '0', false);
$incomes[$currency->id] = app('amount')->formatAnything($currency, '0', false);

2
app/Http/Controllers/Json/FrontpageController.php
View File

@@ -64,7 +64,7 @@ class FrontpageController extends Controller
}
}
$html = '';
if (0!==count($info)) {
if (!empty($info)) {
try {
$html = prefixView('json.piggy-banks', compact('info'))->render();

5
app/Http/Controllers/NewUserController.php
View File

@@ -125,11 +125,6 @@ class NewUserController extends Controller
'invoice_date' => false, 'internal_reference' => false, 'notes' => true, 'attachments' => true,];
app('preferences')->set('transaction_journal_optional_fields', $visibleFields);
// telemetry: user language preference + default language.
app('telemetry')->feature('config.firefly.default_language', config('firefly.default_language', 'en_US'));
app('telemetry')->feature('user.preferences.language', app('steam')->getLanguage());
app('telemetry')->feature('user.preferences.locale', app('steam')->getLocale());
session()->flash('success', (string) trans('firefly.stored_new_accounts_new_user'));
app('preferences')->mark();

5
app/Http/Controllers/PreferencesController.php
View File

@@ -217,11 +217,6 @@ class PreferencesController extends Controller
session()->flash('success', (string)trans('firefly.saved_preferences'));
app('preferences')->mark();
// telemetry: user language preference + default language.
app('telemetry')->feature('config.firefly.default_language', config('firefly.default_language', 'en_US'));
app('telemetry')->feature('user.preferences.language', app('steam')->getLanguage());
app('telemetry')->feature('user.preferences.locale', app('steam')->getLocale());
return redirect(route('preferences.index'));
}
}