kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-29 18:20:01 +00:00
Code Issues Projects Releases Wiki Activity

Code optimisations.

Browse Source
This commit is contained in:
James Cole
2018-07-22 18:50:27 +02:00
parent ea2c48bca5
commit ca096852a5
56 changed files with 221 additions and 427 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/Repositories/Journal/JournalRepository.php
View File

@@ -51,6 +51,7 @@ class JournalRepository implements JournalRepositoryInterface
/** @var User */
private $user;
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* @param TransactionJournal $journal
* @param TransactionType $type
@@ -141,6 +142,7 @@ class JournalRepository implements JournalRepositoryInterface
* @param int $journalId
*
* @return TransactionJournal
* @deprecated
*/
public function find(int $journalId): TransactionJournal
{
@@ -300,6 +302,7 @@ class JournalRepository implements JournalRepositoryInterface
if (null !== $budget) {
return $budget->id;
}
/** @noinspection NullPointerExceptionInspection */
$budget = $journal->transactions()->first()->budgets()->first();
if (null !== $budget) {
return $budget->id;
@@ -321,6 +324,7 @@ class JournalRepository implements JournalRepositoryInterface
if (null !== $category) {
return $category->name;
}
/** @noinspection NullPointerExceptionInspection */
$category = $journal->transactions()->first()->categories()->first();
if (null !== $category) {
return $category->name;
@@ -343,6 +347,7 @@ class JournalRepository implements JournalRepositoryInterface
if (null === $field) {
return $journal->date->format('Y-m-d');
}
/** @noinspection NotOptimalIfConditionsInspection */
if (null !== $journal->$field && $journal->$field instanceof Carbon) {
// make field NULL
$carbon = clone $journal->$field;
@@ -731,7 +736,7 @@ class JournalRepository implements JournalRepositoryInterface
/**
* @param User $user
*/
public function setUser(User $user)
public function setUser(User $user): void
{
$this->user = $user;
}

1
app/Repositories/Journal/JournalRepositoryInterface.php
View File

@@ -39,6 +39,7 @@ use Illuminate\Support\MessageBag;
*/
interface JournalRepositoryInterface
{
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* @param TransactionJournal $journal
* @param TransactionType $type