kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary loops.

Browse Source
This commit is contained in:
James Cole
2019-08-10 07:04:54 +02:00
parent 7b0ccdbdb4
commit cb1db06a7c
5 changed files with 5 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Factory/BudgetFactory.php
View File

@@ -90,17 +90,7 @@ class BudgetFactory
*/
public function findByName(string $name): ?Budget
{
/** @var Collection $collection */
$collection = $this->user->budgets()->get();
// TODO no longer need to loop like this
/** @var Budget $budget */
foreach ($collection as $budget) {
if ($budget->name === $name) {
return $budget;
}
}
return null;
return $this->user->budgets()->where('name', $name)->first();
}
/**

16
app/Factory/CategoryFactory.php
View File

@@ -55,21 +55,7 @@ class CategoryFactory
*/
public function findByName(string $name): ?Category
{
$result = null;
/** @var Collection $collection */
$collection = $this->user->categories()->get();
// TODO no longer need to loop like this
/** @var Category $category */
foreach ($collection as $category) {
if ($category->name === $name) {
$result = $category;
break;
}
}
return $result;
return $this->user->categories()->where('name', $name)->first();
}
/**

13
app/Factory/PiggyBankFactory.php
View File

@@ -90,18 +90,7 @@ class PiggyBankFactory
*/
public function findByName(string $name): ?PiggyBank
{
$set = $this->user->piggyBanks()->get();
// TODO no longer need to loop like this
/** @var PiggyBank $piggy */
foreach ($set as $piggy) {
if ($piggy->name === $name) {
return $piggy;
}
}
return null;
return $this->user->piggyBanks()->where('name', $name)->first();
}
/**