kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-08-03 14:45:37 +02:00
parent 75c2529d3e
commit cf121fea50
16 changed files with 296 additions and 971 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Unit/TransactionRules/Actions/ClearNotesTest.php
View File

@@ -68,6 +68,8 @@ class ClearNotesTest extends TestCase
try {
$result = $action->act($journal);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);

4
tests/Unit/TransactionRules/Actions/ConvertToDepositTest.php
View File

@@ -75,6 +75,8 @@ class ConvertToDepositTest extends TestCase
try {
$result = $action->act($journal);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);
@@ -111,6 +113,8 @@ class ConvertToDepositTest extends TestCase
try {
$result = $action->act($journal);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);

15
tests/Unit/TransactionRules/Actions/ConvertToTransferTest.php
View File

@@ -64,7 +64,10 @@ class ConvertToTransferTest extends TestCase
// mock used stuff:
$accountRepos = $this->mock(AccountRepositoryInterface::class);
$accountRepos->shouldReceive('setUser')->once();
$accountRepos->shouldReceive('findByName')->withArgs([$asset->name, [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE]])->andReturn($asset);
$accountRepos->shouldReceive('findByName')->withArgs(
[$asset->name,
[AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE]]
)->andReturn($asset);
// fire the action:
$rule = new Rule;
@@ -77,6 +80,8 @@ class ConvertToTransferTest extends TestCase
try {
$result = $action->act($deposit);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);
@@ -94,8 +99,10 @@ class ConvertToTransferTest extends TestCase
public function testActWithdrawal(): void
{
$withdrawal = $this->getRandomWithdrawal();
/** @var Account $asset */
$asset = $this->getRandomAsset();
// make sure that $asset is not the source account of $withdrawal:
$forbiddenId = (int)$withdrawal->transactions()->where('amount', '<', 0)->first()->account_id;
$asset = $this->getRandomAsset($forbiddenId);
// mock used stuff:
$accountRepos = $this->mock(AccountRepositoryInterface::class);
@@ -113,6 +120,8 @@ class ConvertToTransferTest extends TestCase
try {
$result = $action->act($withdrawal);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);

4
tests/Unit/TransactionRules/Actions/ConvertToWithdrawalTest.php
View File

@@ -75,6 +75,8 @@ class ConvertToWithdrawalTest extends TestCase
try {
$result = $action->act($deposit);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);
@@ -108,6 +110,8 @@ class ConvertToWithdrawalTest extends TestCase
try {
$result = $action->act($transfer);
} catch (Exception $e) {
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
$this->assertTrue(false, $e->getMessage());
}
$this->assertTrue($result);