kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-30 10:33:30 +00:00
Code Issues Projects Releases Wiki Activity

getIban might return null from the bunq API. Fixes #1378 as it gets imported now :)

Browse Source
This commit is contained in:
Paul Sohier
2018-04-25 19:11:32 +02:00
parent 71f39f55f2
commit d2848cf569
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/Import/Routine/BunqRoutine.php
View File

@@ -320,23 +320,27 @@ class BunqRoutine implements RoutineInterface
private function convertToAccount(LabelMonetaryAccount $party, string $expectedType): Account private function convertToAccount(LabelMonetaryAccount $party, string $expectedType): Account
{ {
Log::debug('in convertToAccount()'); Log::debug('in convertToAccount()');
// find opposing party by IBAN first.
$result = $this->accountRepository->findByIbanNull($party->getIban(), [$expectedType]);
if (null !== $result) {
Log::debug(sprintf('Search for %s resulted in account %s (#%d)', $party->getIban(), $result->name, $result->id));
return $result; if ($party->getIban() !== null) {
} // find opposing party by IBAN first.
$result = $this->accountRepository->findByIbanNull($party->getIban(), [$expectedType]);
// try to find asset account just in case:
if ($expectedType !== AccountType::ASSET) {
$result = $this->accountRepository->findByIbanNull($party->getIban(), [AccountType::ASSET]);
if (null !== $result) { if (null !== $result) {
Log::debug(sprintf('Search for Asset "%s" resulted in account %s (#%d)', $party->getIban(), $result->name, $result->id)); Log::debug(sprintf('Search for %s resulted in account %s (#%d)', $party->getIban(), $result->name, $result->id));
return $result; return $result;
} }
// try to find asset account just in case:
if ($expectedType !== AccountType::ASSET) {
$result = $this->accountRepository->findByIbanNull($party->getIban(), [AccountType::ASSET]);
if (null !== $result) {
Log::debug(sprintf('Search for Asset "%s" resulted in account %s (#%d)', $party->getIban(), $result->name, $result->id));
return $result;
}
}
} }
// create new account: // create new account:
$data = [ $data = [
'user_id' => $this->job->user_id, 'user_id' => $this->job->user_id,