kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-23 12:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Fix various level 4 issues [skip ci]

Browse Source
This commit is contained in:
James Cole
2025-01-04 08:02:05 +01:00
parent ea9f635b1a
commit d4942efd8e
13 changed files with 18 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Handlers/Observer/AccountObserver.php
View File

@@ -56,7 +56,7 @@ class AccountObserver
$account->native_virtual_balance = $converter->convert($currency, $userCurrency, today(), $account->virtual_balance);
}
if ('' === (string) $account->virtual_balance || ('' !== (string) $account->virtual_balance && 0 === bccomp($account->virtual_balance, '0'))) {
if ('' === (string) $account->virtual_balance || (0 === bccomp($account->virtual_balance, '0'))) {
$account->virtual_balance = null;
$account->native_virtual_balance = null;
}

3
app/Handlers/Observer/PiggyBankObserver.php
View File

@@ -71,9 +71,6 @@ class PiggyBankObserver
return;
}
$userCurrency = app('amount')->getDefaultCurrencyByUserGroup($group);
if (null === $userCurrency) {
return;
}
$piggyBank->native_target_amount = null;
if ($piggyBank->transactionCurrency->id !== $userCurrency->id) {
$converter = new ExchangeRateConverter();