From d54e264a9185b30ec4529c1446feb24bbf598086 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 20 May 2016 15:09:25 +0200 Subject: [PATCH] Cannot create empty tags. Signed-off-by: James Cole --- app/Helpers/Csv/Converter/TagsComma.php | 6 ++++-- app/Helpers/Csv/Converter/TagsSpace.php | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/Helpers/Csv/Converter/TagsComma.php b/app/Helpers/Csv/Converter/TagsComma.php index bee90e8025..c9477e7ada 100644 --- a/app/Helpers/Csv/Converter/TagsComma.php +++ b/app/Helpers/Csv/Converter/TagsComma.php @@ -41,8 +41,10 @@ class TagsComma extends BasicConverter implements ConverterInterface 'zoomLevel' => null, 'tagMode' => 'nothing', ]; - $tag = $repository->store($data); // should validate first? - $tags->push($tag); + if (strlen($string) > 0) { + $tag = $repository->store($data); // should validate first? + $tags->push($tag); + } } $tags = $tags->merge($this->data['tags']); diff --git a/app/Helpers/Csv/Converter/TagsSpace.php b/app/Helpers/Csv/Converter/TagsSpace.php index 93ca0d5293..aa2694a330 100644 --- a/app/Helpers/Csv/Converter/TagsSpace.php +++ b/app/Helpers/Csv/Converter/TagsSpace.php @@ -42,8 +42,10 @@ class TagsSpace extends BasicConverter implements ConverterInterface 'zoomLevel' => null, 'tagMode' => 'nothing', ]; - $tag = $repository->store($data); // should validate first? - $tags->push($tag); + if (strlen($string) > 0) { + $tag = $repository->store($data); // should validate first? + $tags->push($tag); + } } $tags = $tags->merge($this->data['tags']);