kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Small optimizations to the reminders

Browse Source
This commit is contained in:
James Cole
2015-03-08 09:00:04 +01:00
parent 9b9bd11ebb
commit d9028ed9b7
4 changed files with 63 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Helpers/Reminders/ReminderHelper.php
View File

@@ -39,9 +39,14 @@ class ReminderHelper implements ReminderHelperInterface
$perReminder = $left / count($ranges);
} else {
$perReminder = null;
$ranges = [];
$left = 0;
}
$metaData = [
'perReminder' => $perReminder
'perReminder' => $perReminder,
'rangesCount' => count($ranges),
'ranges' => $ranges,
'leftToSave' => $left,
];
@@ -97,7 +102,7 @@ class ReminderHelper implements ReminderHelperInterface
$start = $piggyBank->targetdate;
$end = $piggyBank->startdate;
while ($start >= $end) {
while ($start > $end) {
$currentEnd = clone $start;
$start = Navigation::subtractPeriod($start, $piggyBank->reminder, 1);
$currentStart = clone $start;
@@ -129,6 +134,9 @@ class ReminderHelper implements ReminderHelperInterface
{
/** @var PiggyBank $piggyBank */
$piggyBank = $reminder->remindersable;
if(is_null($piggyBank)) {
return 'Piggy bank no longer exists.';
}
if (is_null($piggyBank->targetdate)) {
return 'Add money to this piggy bank to reach your target of ' . Amount::format($piggyBank->targetamount);